Web Animations API: Update interpolation test harness to test element.animate()

Web Animations API: Update interpolation test harness to test element.animate()

The animate() method on Element is severely under tested. This patch makes
use of the existing animation interpolation tests to also test element.animate().
Just over 50% of the tests pass, the failures are being checked in as expected
failures for now as it is representative of the current state of element.animate().

BUG=352472
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169775

[alancutter (OOO until 2018), 2014-03-19 00:16:27]

There's a JS file to review somewhere in there...

[dstockwell, 2014-03-20 00:35:45]

https://codereview.chromium.org/203723005/diff/1/LayoutTests/animations/inter...
File
LayoutTests/animations/interpolation/background-color-interpolation-expected.txt
(right):

https://codereview.chromium.org/203723005/diff/1/LayoutTests/animations/inter...
LayoutTests/animations/interpolation/background-color-interpolation-expected.txt:13:
PASS: backgroundColor from [white] to [orange] was [white] at -0.3
It's not clear what the difference between this and the PASS on line 1 is.

Perhaps we should prefix them (css-animations) (element.animate)

https://codereview.chromium.org/203723005/diff/1/LayoutTests/animations/inter...
File LayoutTests/animations/interpolation/resources/interpolation-test.js
(right):

https://codereview.chromium.org/203723005/diff/1/LayoutTests/animations/inter...
LayoutTests/animations/interpolation/resources/interpolation-test.js:56: var
webAnimationsTest = typeof document.head.animate === 'function';
Element.prototype.animate

https://codereview.chromium.org/203723005/diff/1/LayoutTests/animations/inter...
File
LayoutTests/animations/interpolation/webkit-text-fill-color-interpolation-expected.txt
(left):

https://codereview.chromium.org/203723005/diff/1/LayoutTests/animations/inter...
LayoutTests/animations/interpolation/webkit-text-fill-color-interpolation-expected.txt:1:
PASS: -webkit-text-fill-color from [black] to [orange] was [black] at -0.3
Does the corresponding test no longer exist?

[alancutter (OOO until 2018), 2014-03-20 04:59:55]

https://codereview.chromium.org/203723005/diff/1/LayoutTests/animations/inter...
File
LayoutTests/animations/interpolation/background-color-interpolation-expected.txt
(right):

https://codereview.chromium.org/203723005/diff/1/LayoutTests/animations/inter...
LayoutTests/animations/interpolation/background-color-interpolation-expected.txt:13:
PASS: backgroundColor from [white] to [orange] was [white] at -0.3
On 2014/03/20 00:35:45, dstockwell wrote:
> It's not clear what the difference between this and the PASS on line 1 is.
> 
> Perhaps we should prefix them (css-animations) (element.animate)

Added headers to each test section.

https://codereview.chromium.org/203723005/diff/1/LayoutTests/animations/inter...
File LayoutTests/animations/interpolation/resources/interpolation-test.js
(right):

https://codereview.chromium.org/203723005/diff/1/LayoutTests/animations/inter...
LayoutTests/animations/interpolation/resources/interpolation-test.js:56: var
webAnimationsTest = typeof document.head.animate === 'function';
On 2014/03/20 00:35:45, dstockwell wrote:
> Element.prototype.animate

Done.

https://codereview.chromium.org/203723005/diff/1/LayoutTests/animations/inter...
File
LayoutTests/animations/interpolation/webkit-text-fill-color-interpolation-expected.txt
(left):

https://codereview.chromium.org/203723005/diff/1/LayoutTests/animations/inter...
LayoutTests/animations/interpolation/webkit-text-fill-color-interpolation-expected.txt:1:
PASS: -webkit-text-fill-color from [black] to [orange] was [black] at -0.3
On 2014/03/20 00:35:45, dstockwell wrote:
> Does the corresponding test no longer exist?

Correct, the feature was removed but the test expectations remained.

[dstockwell, 2014-03-20 05:47:23]

lgtm

https://codereview.chromium.org/203723005/diff/20001/LayoutTests/animations/i...
File LayoutTests/animations/interpolation/resources/interpolation-test.js
(right):

https://codereview.chromium.org/203723005/diff/20001/LayoutTests/animations/i...
LayoutTests/animations/interpolation/resources/interpolation-test.js:289:
function makeInterpolationTest(cssTest, fraction, testId, caseId, params,
expectation) {
Instead of a boolean parameter, cssTest could be 'kind' with a string of either
'css' or 'web-animations'. This would make the callsite easier to understand.

https://codereview.chromium.org/203723005/diff/20001/LayoutTests/animations/i...
LayoutTests/animations/interpolation/resources/interpolation-test.js:301:
target.isCSSTest = cssTest;
here too

[alancutter (OOO until 2018), 2014-03-20 05:55:57]

https://codereview.chromium.org/203723005/diff/20001/LayoutTests/animations/i...
File LayoutTests/animations/interpolation/resources/interpolation-test.js
(right):

https://codereview.chromium.org/203723005/diff/20001/LayoutTests/animations/i...
LayoutTests/animations/interpolation/resources/interpolation-test.js:289:
function makeInterpolationTest(cssTest, fraction, testId, caseId, params,
expectation) {
On 2014/03/20 05:47:24, dstockwell wrote:
> Instead of a boolean parameter, cssTest could be 'kind' with a string of
either
> 'css' or 'web-animations'. This would make the callsite easier to understand.

Done.

https://codereview.chromium.org/203723005/diff/20001/LayoutTests/animations/i...
LayoutTests/animations/interpolation/resources/interpolation-test.js:301:
target.isCSSTest = cssTest;
On 2014/03/20 05:47:24, dstockwell wrote:
> here too

Done.

[alancutter (OOO until 2018), 2014-03-20 05:56:06]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2014-03-20 05:56:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/203723005/40001

[commit-bot: I haz the power, 2014-03-20 05:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 05:58:14]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_compile_dbg

[alancutter (OOO until 2018), 2014-03-22 01:47:58]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2014-03-22 01:48:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alancutter@chromium.org/203723005/60001

[commit-bot: I haz the power, 2014-03-22 04:10:10]

Change committed as 169775