Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2037193002: Unref GrXPFactory. (Closed)

Created:
4 years, 6 months ago by bungeman-skia
Modified:
4 years, 6 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Unref GrXPFactory. Not releasing the reference was caught by asan in the Chromium roll. This fixes "Make GrClipMaskManager stateless and push GrPipelineBuilder construction downstack". Committed: https://skia.googlesource.com/skia/+/ab0bf2ef82cdfc92d6dbef2d9949be24a7b88533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/GrDrawContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
bungeman-skia
4 years, 6 months ago (2016-06-03 21:08:39 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037193002/1
4 years, 6 months ago (2016-06-03 21:10:02 UTC) #6
herb_g
lgtm
4 years, 6 months ago (2016-06-03 21:10:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037193002/1
4 years, 6 months ago (2016-06-03 21:12:01 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 21:25:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ab0bf2ef82cdfc92d6dbef2d9949be24a7b88533

Powered by Google App Engine
This is Rietveld 408576698