Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2037153002: [cleanup] Inline HAS_INDEX macro as it's trivially the 'in' operator (Closed)

Created:
4 years, 6 months ago by adamk
Modified:
4 years, 6 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Inline HAS_INDEX macro as it's trivially the 'in' operator R=cbruni@chromium.org Committed: https://crrev.com/4cc2a73185f2d86ac6b18fd8935bb1f72ad9f3d8 Cr-Commit-Position: refs/heads/master@{#36723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M src/js/array.js View 12 chunks +13 lines, -13 lines 0 comments Download
M src/js/macros.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
adamk
4 years, 6 months ago (2016-06-03 18:05:05 UTC) #1
Camillo Bruni
ah so clean :) LGTM
4 years, 6 months ago (2016-06-03 20:02:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037153002/1
4 years, 6 months ago (2016-06-03 20:06:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037153002/1
4 years, 6 months ago (2016-06-03 20:08:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 20:09:07 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 20:09:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cc2a73185f2d86ac6b18fd8935bb1f72ad9f3d8
Cr-Commit-Position: refs/heads/master@{#36723}

Powered by Google App Engine
This is Rietveld 408576698