content/common/font_config_ipc_linux.h - Issue 2037133002: SkFontConfigInterface createTypeface to makeTypeface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/font_config_ipc_linux.h

Issue 2037133002: SkFontConfigInterface createTypeface to makeTypeface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move comes from utility. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/font_config_ipc_linux.h

diff --git a/content/common/font_config_ipc_linux.h b/content/common/font_config_ipc_linux.h

index be07519d497be9901cb42b25af33bbea513d58bd..258c200208324418fa14e29c1ef94377a246e731 100644

--- a/content/common/font_config_ipc_linux.h

+++ b/content/common/font_config_ipc_linux.h

@@ -41,7 +41,7 @@ class FontConfigIPC : public SkFontConfigInterface {

// Returns a new SkTypeface instance or a ref'ed one from the cache. The

drott 2016/06/07 07:06:15 I guess this comment can be removed, or at least u

// caller should adopt the pointer.

- SkTypeface* createTypeface(const FontIdentity& identity) override

+ sk_sp<SkTypeface> makeTypeface(const FontIdentity& identity) override

WARN_UNUSED_RESULT;

enum Method {

« no previous file with comments | « no previous file | content/common/font_config_ipc_linux.cc » ('j') | no next file with comments »