third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp - Issue 2037133002: SkFontConfigInterface createTypeface to makeTypeface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

Issue 2037133002: SkFontConfigInterface createTypeface to makeTypeface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp b/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

index 780d5675245257450b0af5714daf1d93716f5652..b532804319a26a49e614cc9a826071c1af80569c 100644

--- a/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

+++ b/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

@@ -54,7 +54,7 @@ static PassRefPtr<SkTypeface> typefaceForFontconfigInterfaceIdAndTtcIndex(int fo

SkFontConfigInterface::FontIdentity fontIdentity;

fontIdentity.fID = fontconfigInterfaceId;

fontIdentity.fTTCIndex = ttcIndex;

- return adoptRef(fci->createTypeface(fontIdentity));

+ return adoptRef(fci->makeTypeface(fontIdentity).release());

f(malita) 2016/06/03 17:11:59 Nit: return fromSkSp(fci->makeTypeface(fontIdentit

bungeman-chromium 2016/06/03 18:28:18 Thanks, I thought something like this existed, but

}

#endif

« content/common/font_config_ipc_linux.cc ('K') | « content/common/font_config_ipc_linux.cc ('k') | no next file » | no next file with comments »