Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2037093002: Null-check PaintLayerScrollableArea lookup. (Closed)

Created:
4 years, 6 months ago by chrishtr
Modified:
4 years, 6 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Null-check PaintLayerScrollableArea lookup. BUG=616633 Committed: https://crrev.com/6eb006ccd5f60bfc3a9b2125321cd8ffa4fc8c86 Cr-Commit-Position: refs/heads/master@{#397747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
chrishtr
It's a little bit speculative since I have not reproduced one of the crashes, but ...
4 years, 6 months ago (2016-06-03 15:26:26 UTC) #3
Xianzhu
lgtm
4 years, 6 months ago (2016-06-03 16:10:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2037093002/1
4 years, 6 months ago (2016-06-03 16:10:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 17:44:35 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 17:46:25 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6eb006ccd5f60bfc3a9b2125321cd8ffa4fc8c86
Cr-Commit-Position: refs/heads/master@{#397747}

Powered by Google App Engine
This is Rietveld 408576698