tools/android/loading Switch from multiprocessing Pool to Process

tools/android/loading Switch from multiprocessing Pool to Process

Pool does not allow to hard kill a process, which can lead
to process leaks if a process does not die on terminate.

Pool also sometimes crashes the main process in terminate(),
interrupting trace generation.

Committed: https://crrev.com/1c8f4c8908c64620cc2becdc971c3b779d9827b2
Cr-Commit-Position: refs/heads/master@{#398041}

[droger, 2016-06-03 15:39:39]

Description was changed from

==========
tools/android/loading Switch to from multiprocessing Pool to Process
==========

to

==========
tools/android/loading Switch from multiprocessing Pool to Process
==========

[droger, 2016-06-03 15:41:44]

Description was changed from

==========
tools/android/loading Switch from multiprocessing Pool to Process
==========

to

==========
tools/android/loading Switch from multiprocessing Pool to Process

Pool does not allow to hard kill a process, which can lead
to process leaks if a process does not die on terminate.

Pool also sometimes crashes the main process in terminate(),
interrupting trace generation.
==========

[droger, 2016-06-06 13:43:34]

Patchset #3 (id:40001) has been deleted

[droger, 2016-06-06 13:43:51]

Patchset #1 (id:1) has been deleted

[droger, 2016-06-06 13:44:13]

Patchset #2 (id:60001) has been deleted

[droger, 2016-06-06 14:03:50]

droger@chromium.org changed reviewers:
+ blundell@chromium.org, lizeb@chromium.org, mattcary@chromium.org

[droger, 2016-06-06 14:03:51]

I could not repro the issue, but I hope this CL should address it.
In any case, even if it does not solve the issue, I think this should be better,
because it really kills the process (SIGTERM then SIGKILL) whereas the Pool did
not (SIGTERM only).

[mattcary, 2016-06-06 14:10:23]

lgtm

[blundell, 2016-06-06 14:12:00]

looks fine to me, but Benoit should take a look too

https://codereview.chromium.org/2037073002/diff/80001/tools/android/loading/c...
File tools/android/loading/cloud/backend/multiprocessing_helper.py (right):

https://codereview.chromium.org/2037073002/diff/80001/tools/android/loading/c...
tools/android/loading/cloud/backend/multiprocessing_helper.py:47: def
RunOutOfProcess(function, args, logger, timeout_seconds, memory_share=None):
nit: maybe RunInSeparateProcess()?

[Benoit L, 2016-06-06 15:28:13]

On 2016/06/06 14:12:00, blundell wrote:
> looks fine to me, but Benoit should take a look too
> 
>
https://codereview.chromium.org/2037073002/diff/80001/tools/android/loading/c...
> File tools/android/loading/cloud/backend/multiprocessing_helper.py (right):
> 
>
https://codereview.chromium.org/2037073002/diff/80001/tools/android/loading/c...
> tools/android/loading/cloud/backend/multiprocessing_helper.py:47: def
> RunOutOfProcess(function, args, logger, timeout_seconds, memory_share=None):
> nit: maybe RunInSeparateProcess()?

lgtm

[droger, 2016-06-06 15:37:08]

The CQ bit was checked by droger@chromium.org

[droger, 2016-06-06 15:37:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
mattcary@chromium.org
Link to the patchset: https://codereview.chromium.org/2037073002/#ps100001
(title: "Review comments")

[commit-bot: I haz the power, 2016-06-06 15:37:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037073002/100001

[commit-bot: I haz the power, 2016-06-06 16:12:49]

Description was changed from

==========
tools/android/loading Switch from multiprocessing Pool to Process

Pool does not allow to hard kill a process, which can lead
to process leaks if a process does not die on terminate.

Pool also sometimes crashes the main process in terminate(),
interrupting trace generation.
==========

to

==========
tools/android/loading Switch from multiprocessing Pool to Process

Pool does not allow to hard kill a process, which can lead
to process leaks if a process does not die on terminate.

Pool also sometimes crashes the main process in terminate(),
interrupting trace generation.
==========

[commit-bot: I haz the power, 2016-06-06 16:12:50]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-06-06 16:14:06]

Description was changed from

==========
tools/android/loading Switch from multiprocessing Pool to Process

Pool does not allow to hard kill a process, which can lead
to process leaks if a process does not die on terminate.

Pool also sometimes crashes the main process in terminate(),
interrupting trace generation.
==========

to

==========
tools/android/loading Switch from multiprocessing Pool to Process

Pool does not allow to hard kill a process, which can lead
to process leaks if a process does not die on terminate.

Pool also sometimes crashes the main process in terminate(),
interrupting trace generation.

Committed: https://crrev.com/1c8f4c8908c64620cc2becdc971c3b779d9827b2
Cr-Commit-Position: refs/heads/master@{#398041}
==========

[commit-bot: I haz the power, 2016-06-06 16:14:07]

Patchset 3 (id:??) landed as
https://crrev.com/1c8f4c8908c64620cc2becdc971c3b779d9827b2
Cr-Commit-Position: refs/heads/master@{#398041}