Issue 203703002: A64: Abstract simulation of runtime calls in a separate function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203703002: A64: Abstract simulation of runtime calls in a separate function. (Closed)

Created:
6 years, 9 months ago by Alexandre Rames

Modified:
6 years, 9 months ago

Reviewers:
ulan, jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

A64: Abstract simulation of runtime calls in a separate function. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20107

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+222 lines, -221 lines)			Patch
	M	src/a64/simulator-a64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/a64/simulator-a64.cc	View		5 chunks	+221 lines, -221 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

lgtm https://codereview.chromium.org/203703002/diff/1/src/a64/simulator-a64.cc File src/a64/simulator-a64.cc (right): https://codereview.chromium.org/203703002/diff/1/src/a64/simulator-a64.cc#newcode473 src/a64/simulator-a64.cc:473: T external_function() { return reinterpret_cast<T>(external_function_); } Indentation is ...

6 years, 9 months ago (2014-03-19 08:53:18 UTC) #2

Alexandre Rames

https://codereview.chromium.org/203703002/diff/1/src/a64/simulator-a64.cc File src/a64/simulator-a64.cc (right): https://codereview.chromium.org/203703002/diff/1/src/a64/simulator-a64.cc#newcode473 src/a64/simulator-a64.cc:473: T external_function() { return reinterpret_cast<T>(external_function_); } On 2014/03/19 08:53:19, ...

6 years, 9 months ago (2014-03-20 09:49:33 UTC) #3

Alexandre Rames

6 years, 9 months ago (2014-03-20 09:51:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r20107 (presubmit successful).

Expand Messages | Collapse Messages