Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2037013003: Initialize stub platform window bounds to those of its mus::Window. (Closed)

Created:
4 years, 6 months ago by msw
Modified:
4 years, 6 months ago
Reviewers:
sadrul, sky, Mark Dittmer
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize stub platform window bounds to those of its mus::Window. Fixes a regression from https://codereview.chromium.org/2009853002 IDK why it matters or if it relates to [still] broken window dragging. TODO: Fix wallpaper picker dragging (not broken by same CL)... BUG=557405 TEST=wallpaper picker shows for "Set wallpaper..." in mash. R=markdittmer@chromium.org,sky@chromium.org,sadrul@chromium.org Committed: https://crrev.com/6ac5be6880e84f4be61d7d8e63b1ff8283f7735c Cr-Commit-Position: refs/heads/master@{#397873}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/views/mus/window_tree_host_mus.cc View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 14 (6 generated)
msw
Hey Mark, Scott, Sadrul, please take a look; thanks! (wide distro for better ideas on ...
4 years, 6 months ago (2016-06-03 21:24:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037013003/1
4 years, 6 months ago (2016-06-03 21:25:07 UTC) #4
sky
LGTM https://codereview.chromium.org/2037013003/diff/1/ui/views/mus/window_tree_host_mus.cc File ui/views/mus/window_tree_host_mus.cc (right): https://codereview.chromium.org/2037013003/diff/1/ui/views/mus/window_tree_host_mus.cc#newcode58 ui/views/mus/window_tree_host_mus.cc:58: platform_window()->SetBounds(window->bounds()); This seems right to me. I see ...
4 years, 6 months ago (2016-06-03 22:12:52 UTC) #5
sky
Actually, turned out not to be a bug but rather some unnecessary code. On Fri, ...
4 years, 6 months ago (2016-06-03 22:39:21 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-04 00:47:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037013003/1
4 years, 6 months ago (2016-06-04 00:52:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 00:57:45 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 01:00:42 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ac5be6880e84f4be61d7d8e63b1ff8283f7735c
Cr-Commit-Position: refs/heads/master@{#397873}

Powered by Google App Engine
This is Rietveld 408576698