Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2036993003:
Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR. (Closed)
|
Created:
4 years, 6 months ago by bungeman-skia Modified:
4 years, 6 months ago Reviewers:
tomhudson CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionRemove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR.
Some of the deprecated signatures are no longer used by any known
client, so remove them now to prevent future use.
TBR=reed
This doesn't add API, it just removes it.
Committed: https://skia.googlesource.com/skia/+/69df0206252ce0e6293c60274a1dfc363bb2e3b5
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
Description was changed from ========== Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR. Some of the deprecated signatures are no longer used by any known client, so remove them now to prevent future use. ========== to ========== Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR. Some of the deprecated signatures are no longer used by any known client, so remove them now to prevent future use. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2036993003 ==========
Description was changed from ========== Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR. Some of the deprecated signatures are no longer used by any known client, so remove them now to prevent future use. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2036993003 ========== to ========== Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR. Some of the deprecated signatures are no longer used by any known client, so remove them now to prevent future use. ==========
The CQ bit was checked by bungeman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036993003/1
Description was changed from ========== Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR. Some of the deprecated signatures are no longer used by any known client, so remove them now to prevent future use. ========== to ========== Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR. Some of the deprecated signatures are no longer used by any known client, so remove them now to prevent future use. COMMIT=false Depends on https://codereview.chromium.org/2037133002/ landing first. ==========
bungeman@google.com changed reviewers: + tomhudson@google.com
Checked against Android? If so, LGTM.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR. Some of the deprecated signatures are no longer used by any known client, so remove them now to prevent future use. COMMIT=false Depends on https://codereview.chromium.org/2037133002/ landing first. ========== to ========== Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR. Some of the deprecated signatures are no longer used by any known client, so remove them now to prevent future use. ==========
The CQ bit was checked by bungeman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036993003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from ========== Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR. Some of the deprecated signatures are no longer used by any known client, so remove them now to prevent future use. ========== to ========== Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR. Some of the deprecated signatures are no longer used by any known client, so remove them now to prevent future use. TBR=reed This doesn't add API, it just removes it. ==========
The CQ bit was checked by bungeman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036993003/1
Message was sent while issue was closed.
Description was changed from ========== Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR. Some of the deprecated signatures are no longer used by any known client, so remove them now to prevent future use. TBR=reed This doesn't add API, it just removes it. ========== to ========== Remove some uses of SK_SUPPORT_LEGACY_TYPEFACE_PTR. Some of the deprecated signatures are no longer used by any known client, so remove them now to prevent future use. TBR=reed This doesn't add API, it just removes it. Committed: https://skia.googlesource.com/skia/+/69df0206252ce0e6293c60274a1dfc363bb2e3b5 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/69df0206252ce0e6293c60274a1dfc363bb2e3b5 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
