Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2036993002: Revert of Switch WTF::find on LChar to use memchr. (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
Reviewers:
Nico, jbroman
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, danakj, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch WTF::find on LChar to use memchr. (patchset #1 id:1 of https://codereview.chromium.org/1948543004/ ) Reason for revert: LSAN and MSAN bots appear unhappy: http/tests/media/media-source/mediasource-is-type-supported.html crash log for renderer (pid <unknown>): STDOUT: <empty> STDERR: ================================================================= STDERR: ==4==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6030000982af at pc 0x00000045811f bp 0x7fff2f309830 sp 0x7fff2f308fe0 STDERR: READ of size 5006 at 0x6030000982af thread T0 (content_shell) STDERR: #0 0x45811e in memchr ??:0 STDERR: #1 0x3c5c419 in find third_party/WebKit/Source/wtf/text/StringImpl.h:532:9 STDERR: #2 0x3c5c419 in find third_party/WebKit/Source/wtf/text/StringImpl.h:660:0 STDERR: #3 0x3c5c419 in find third_party/WebKit/Source/wtf/text/WTFString.h:214:0 STDERR: #4 0x3c5c419 in find third_party/WebKit/Source/wtf/text/WTFString.h:215:0 STDERR: #5 0x3c5c419 in parameter third_party/WebKit/Source/platform/ContentType.cpp:50:0 STDERR: #6 0x8d64b7d in isTypeSupported third_party/WebKit/Source/modules/mediasource/MediaSource.cpp:244:33 STDERR: #7 0x9251198 in isTypeSupportedMethod ./out/Release/gen/blink/bindings/modules/v8/V8MediaSource.cpp:234:32 STDERR: #8 0x9251198 in isTypeSupportedMethodCallback ./out/Release/gen/blink/bindings/modules/v8/V8MediaSource.cpp:239:0 STDERR: #9 0x444b759 in Call v8/src/api-arguments.cc:16:3 (https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_ASAN/24421/layout-test-results/results.html) Original issue's description: > Switch WTF::find on LChar to use memchr. > > BUG=607208 > > Committed: https://crrev.com/c9f9af30569ac2cd353e234f569052db6ab436f4 > Cr-Commit-Position: refs/heads/master@{#397568} TBR=thakis@chromium.org,jbroman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607208 Committed: https://crrev.com/08438794f10a999c095ad758cae293c7a1beff0f Cr-Commit-Position: refs/heads/master@{#397664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M third_party/WebKit/Source/wtf/text/StringImpl.h View 3 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
Created Revert of Switch WTF::find on LChar to use memchr.
4 years, 6 months ago (2016-06-03 08:23:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036993002/1
4 years, 6 months ago (2016-06-03 08:23:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 08:23:55 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 08:26:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08438794f10a999c095ad758cae293c7a1beff0f
Cr-Commit-Position: refs/heads/master@{#397664}

Powered by Google App Engine
This is Rietveld 408576698