Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2036983004: Default the PacHttpsUrlStrippingEnabled policy to False for Chrome OS enterprise users. (Closed)

Created:
4 years, 6 months ago by eroman
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tnagel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Default the PacHttpsUrlStrippingEnabled policy to False for Chrome OS enterprise users. (The plan is to control rollout from the server side, out of concern over compatibility.) BUG=616396 Committed: https://crrev.com/20733647674a30aca99305ebfcfbabc16a8ef958 Cr-Commit-Position: refs/heads/master@{#398797}

Patch Set 1 #

Patch Set 2 : fix chromeos test #

Patch Set 3 : one more #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 chunk +18 lines, -2 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
eroman
This is what you had in mind right? (This should be the last of the ...
4 years, 6 months ago (2016-06-03 21:45:23 UTC) #2
Thiemo Nagel
Nit: It's Chrome OS, not ChromeOS.
4 years, 6 months ago (2016-06-06 18:38:08 UTC) #3
Andrew T Wilson (Slow)
lgtm https://codereview.chromium.org/2036983004/diff/40001/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2036983004/diff/40001/components/policy/resources/policy_templates.json#newcode8616 components/policy/resources/policy_templates.json:8616: The desire is to remove this override in ...
4 years, 6 months ago (2016-06-07 12:59:02 UTC) #4
eroman
> Nit: It's Chrome OS, not ChromeOS. Done
4 years, 6 months ago (2016-06-09 06:21:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036983004/40001
4 years, 6 months ago (2016-06-09 06:21:53 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 06:31:02 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 06:32:28 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/20733647674a30aca99305ebfcfbabc16a8ef958
Cr-Commit-Position: refs/heads/master@{#398797}

Powered by Google App Engine
This is Rietveld 408576698