Issue 2036983002: (CANCELED) Add CreateElementFlags::DisableCustomElements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2036983002: (CANCELED) Add CreateElementFlags::DisableCustomElements (Closed)

Created:
4 years, 6 months ago by kojii

Modified:
4 years, 6 months ago

Reviewers:
dominicc (has gone to gerrit)

CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add CreateElementFlags::DisableCustomElements This patch adds DisableCustomElements flag for V8HTMLElement::constructorCustom to use. BUG=594918

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/core/dom/Document.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/dom/custom/CustomElement.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kojii

PTAL. See https://codereview.chromium.org/2033253003 for V8HTMLElement changes.

4 years, 6 months ago (2016-06-03 06:57:46 UTC) #2

kojii

4 years, 6 months ago (2016-06-03 09:18:24 UTC) #3

Cancelling this as your CL is landing faster than I thought :-)

I'll send me comprehensive one.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages