Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 203693004: Set the name of several iframes in browser resources (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Set the name of several iframes in browser resources Set the name of several iframes in browser resources in addition to their id, to avoid breakage when Blink gets updated so that an iframe's name is no longer set to its id when missing (as per specification). Several scripts / browser tests rely on the iframe's name being the same. I missed several in my previous CL. R=arv, jochen BUG=347169 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/resources/chromeos/charger_replacement.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_eula.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/mobile_setup.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/mobile_setup_portal.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/gaia_auth/main.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
This should be the last of it. Several ChromeOS js scripts rely on $("frame-name").
6 years, 9 months ago (2014-03-18 17:41:18 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-20 10:12:57 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-20 12:02:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/203693004/1
6 years, 9 months ago (2014-03-20 12:02:56 UTC) #4
commit-bot: I haz the power
Change committed as 258299
6 years, 9 months ago (2014-03-20 15:02:22 UTC) #5
arv (Not doing code reviews)
6 years, 9 months ago (2014-03-22 16:29:22 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698