Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 203693003: BatteryStatus: fix chargingTime() to follow the specification. (Closed)

Created:
6 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

BatteryStatus: fix chargingTime() to follow the specification. If the battery status is unknown, the charging time should be 0 instead of Infinity. The reason being that in that case, the battery status is reflected as a plugged and fully charged battery. BUG=122593 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170338

Patch Set 1 #

Patch Set 2 : update test results #

Messages

Total messages: 18 (0 generated)
mlamouri (slow - plz ping)
6 years, 9 months ago (2014-03-27 13:28:07 UTC) #1
abarth-chromium
BUG=TODO <--- ? Maybe just remove that line? I might add some explanation about what ...
6 years, 9 months ago (2014-03-27 20:47:19 UTC) #2
abarth-chromium
LGTM w/ improved description
6 years, 9 months ago (2014-03-27 20:47:58 UTC) #3
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-28 14:00:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/203693003/20001
6 years, 9 months ago (2014-03-28 14:00:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 14:32:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-28 14:32:24 UTC) #7
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-28 14:49:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/203693003/20001
6 years, 9 months ago (2014-03-28 14:49:36 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 14:59:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-28 14:59:50 UTC) #11
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-28 15:00:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/203693003/20001
6 years, 9 months ago (2014-03-28 15:00:37 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 15:26:19 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-28 15:26:19 UTC) #15
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 9 months ago (2014-03-28 15:43:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/203693003/20001
6 years, 9 months ago (2014-03-28 15:43:21 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 16:17:41 UTC) #18
Message was sent while issue was closed.
Change committed as 170338

Powered by Google App Engine
This is Rietveld 408576698