Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: extensions/renderer/api_test_base.cc

Issue 2036863002: Remove use of deprecated MessageLoop methods in extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/state_store.cc ('k') | extensions/renderer/gc_callback.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_test_base.cc
diff --git a/extensions/renderer/api_test_base.cc b/extensions/renderer/api_test_base.cc
index 0a5e458aba80aa80ded539a610fe8eaab7c3c50a..47b5c2ade4c65e23dc1c57d906d969dd20bc7685 100644
--- a/extensions/renderer/api_test_base.cc
+++ b/extensions/renderer/api_test_base.cc
@@ -7,7 +7,10 @@
#include <utility>
#include <vector>
+#include "base/location.h"
#include "base/run_loop.h"
+#include "base/single_thread_task_runner.h"
+#include "base/threading/thread_task_runner_handle.h"
#include "extensions/common/extension_urls.h"
#include "extensions/renderer/dispatcher.h"
#include "extensions/renderer/process_info_native_handler.h"
@@ -48,7 +51,7 @@ class TestNatives : public gin::Wrappable<TestNatives> {
}
void FinishTesting() {
- base::MessageLoop::current()->PostTask(FROM_HERE, quit_closure_);
+ base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, quit_closure_);
}
static gin::WrapperInfo kWrapperInfo;
@@ -186,11 +189,11 @@ void ApiTestEnvironment::RunTest(const std::string& file_name,
env()->isolate(),
"testNatives",
TestNatives::Create(env()->isolate(), run_loop.QuitClosure()).ToV8());
- base::MessageLoop::current()->PostTask(
+ base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE,
base::Bind(&ApiTestEnvironment::RunTestInner, base::Unretained(this),
test_name, run_loop.QuitClosure()));
- base::MessageLoop::current()->PostTask(
+ base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::Bind(&ApiTestEnvironment::RunPromisesAgain,
base::Unretained(this)));
run_loop.Run();
@@ -203,14 +206,14 @@ void ApiTestEnvironment::RunTestInner(const std::string& test_name,
v8::Local<v8::Value> result =
env()->module_system()->CallModuleMethod("testBody", test_name);
if (!result->IsTrue()) {
- base::MessageLoop::current()->PostTask(FROM_HERE, quit_closure);
+ base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, quit_closure);
FAIL() << "Failed to run test \"" << test_name << "\"";
}
}
void ApiTestEnvironment::RunPromisesAgain() {
v8::MicrotasksScope::PerformCheckpoint(env()->isolate());
- base::MessageLoop::current()->PostTask(
+ base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::Bind(&ApiTestEnvironment::RunPromisesAgain,
base::Unretained(this)));
}
« no previous file with comments | « extensions/browser/state_store.cc ('k') | extensions/renderer/gc_callback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698