Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2036843002: Rebaseline failing tests due to color fonts change (Closed)

Created:
4 years, 6 months ago by Ilya Kulshin
Modified:
4 years, 6 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Some existing tests started failing after color fonts landed. Not sure why the tryjob didn't catch them. Adding new baselines in any case. BUG=616692 Committed: https://crrev.com/2902d31c2d56de96e0e2e737ba5c9a331cae8632 Cr-Commit-Position: refs/heads/master@{#397590}

Patch Set 1 #

Messages

Total messages: 18 (7 generated)
Ilya Kulshin
4 years, 6 months ago (2016-06-02 21:21:27 UTC) #3
scottmg
what's going on in third_party/WebKit/LayoutTests/platform/win7/svg/text/surrogate-pair-queries-expected.png (nothing on rhs)?
4 years, 6 months ago (2016-06-02 21:24:11 UTC) #4
Ilya Kulshin
On 2016/06/02 21:24:11, scottmg (ooo june 3rd) wrote: > what's going on in > third_party/WebKit/LayoutTests/platform/win7/svg/text/surrogate-pair-queries-expected.png ...
4 years, 6 months ago (2016-06-02 21:30:29 UTC) #5
Ilya Kulshin
On 2016/06/02 21:30:29, Ilya Kulshin wrote: > On 2016/06/02 21:24:11, scottmg (ooo june 3rd) wrote: ...
4 years, 6 months ago (2016-06-02 21:31:09 UTC) #6
scottmg
lgtm
4 years, 6 months ago (2016-06-02 21:31:55 UTC) #7
scottmg
On 2016/06/02 21:31:09, Ilya Kulshin wrote: > On 2016/06/02 21:30:29, Ilya Kulshin wrote: > > ...
4 years, 6 months ago (2016-06-02 21:32:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036843002/1
4 years, 6 months ago (2016-06-02 22:05:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/240270)
4 years, 6 months ago (2016-06-03 00:21:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036843002/1
4 years, 6 months ago (2016-06-03 00:23:56 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 02:38:08 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 02:41:10 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2902d31c2d56de96e0e2e737ba5c9a331cae8632
Cr-Commit-Position: refs/heads/master@{#397590}

Powered by Google App Engine
This is Rietveld 408576698