Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 203683007: Revert of Enable extended debugging symbols to including macro expansion. (Closed)

Created:
6 years, 9 months ago by pneubeck (no reviews)
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Enable extended debugging symbols to including macro expansion. (https://codereview.chromium.org/198363002/) Reason for revert: Might be the cause for memory exhaustion during compilation on the Linux dbg build bot: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Builder%20%28dbg%29%2832%29&number=21991 Original issue's description: > Adding -g3 to get macro expansion support. (Default is -g2.) > Adding -gdwarf-4 for macro expansion support. > > * gcc 4.6 outputs DWARF-2 by default > * gcc 4.7 outputs DWARF-4 by default > * clang <3.4 outputs DWARF-3 by default > * clang >3.4 outputs DWARF-4 by default > > From http://gcc.gnu.org/onlinedocs/gcc/Debugging-Options.html > > -g3 > > Level 3 includes extra information, such as all the macro > > definitions present in the program. Some debuggers support macro > > expansion when you use -g3. > > > > -gdwarf-4 > > Produce debugging information in DWARF format (if that is > > supported). The value of version may be either 2, 3 or 4; the > > default version for most targets is 4. Note that with DWARF > > Version 2, some ports require and always use some non-conflicting > > DWARF 3 extensions in the unwind tables. > > > > Version 4 may require GDB 7.0 and -fvar-tracking-assignments for > > maximum benefit. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257944 TBR=stuartmorgan@chromium.org,erg@chromium.org,mark@chromium.org,mmoss@chromium.org,thestig@chromium.org,mmoss@google.com,mithro@mithis.com NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257959

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M build/common.gypi View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pneubeck (no reviews)
Created Revert of Enable extended debugging symbols to including macro expansion.
6 years, 9 months ago (2014-03-19 13:52:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/203683007/1
6 years, 9 months ago (2014-03-19 13:52:29 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 13:53:20 UTC) #3
Message was sent while issue was closed.
Change committed as 257959

Powered by Google App Engine
This is Rietveld 408576698