Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 203683002: BatteryStatus: use 'unrestricted double' instead of 'double' (Closed)

Created:
6 years, 9 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 7 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

BatteryStatus: use 'unrestricted double' instead of 'double' Even though it seems to be the same as far as our WebIDL parser is concerned, it might be better to keep the IDL as close to the specification as we can. BUG=122593 TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173079

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/modules/battery/BatteryManager.idl View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
mlamouri (slow - plz ping)
6 years, 9 months ago (2014-03-18 21:45:53 UTC) #1
abarth-chromium
nbarth is probably a better reviewer for this CL.
6 years, 9 months ago (2014-03-18 22:53:42 UTC) #2
Nils Barth (inactive)
not LGTM Thanks for your interest in improving Blink IDL usage Mounir! We do not ...
6 years, 9 months ago (2014-03-20 03:30:30 UTC) #3
mlamouri (slow - plz ping)
On 2014/03/20 03:30:30, Nils Barth wrote: > not LGTM > > Thanks for your interest ...
6 years, 9 months ago (2014-03-20 10:43:27 UTC) #4
Nils Barth (inactive)
In brief: I'm adding support for this distinction right now; could you hold off until ...
6 years, 9 months ago (2014-03-24 06:57:44 UTC) #5
mlamouri (slow - plz ping)
If you are working on that, I guess I could just wait, there is no ...
6 years, 9 months ago (2014-03-24 14:33:40 UTC) #6
Nils Barth (inactive)
On 2014/03/24 14:33:40, Mounir Lamouri wrote: > If you are working on that, I guess ...
6 years, 9 months ago (2014-03-25 09:51:40 UTC) #7
mlamouri (slow - plz ping)
On 2014/03/25 09:51:40, Nils Barth wrote: > On 2014/03/24 14:33:40, Mounir Lamouri wrote: > > ...
6 years, 7 months ago (2014-04-30 09:01:39 UTC) #8
Nils Barth (inactive)
On 2014/04/30 09:01:39, Mounir Lamouri wrote: > On 2014/03/25 09:51:40, Nils Barth wrote: > > ...
6 years, 7 months ago (2014-05-01 01:17:54 UTC) #9
Nils Barth (inactive)
A few IDL nits, otherwise LGTM! https://codereview.chromium.org/203683002/diff/1/Source/modules/battery/BatteryManager.idl File Source/modules/battery/BatteryManager.idl (right): https://codereview.chromium.org/203683002/diff/1/Source/modules/battery/BatteryManager.idl#newcode5 Source/modules/battery/BatteryManager.idl:5: // http://dev.w3.org/2009/dap/system-info/battery-status.html More ...
6 years, 7 months ago (2014-05-01 01:19:50 UTC) #10
mlamouri (slow - plz ping)
https://codereview.chromium.org/203683002/diff/1/Source/modules/battery/BatteryManager.idl File Source/modules/battery/BatteryManager.idl (right): https://codereview.chromium.org/203683002/diff/1/Source/modules/battery/BatteryManager.idl#newcode5 Source/modules/battery/BatteryManager.idl:5: // http://dev.w3.org/2009/dap/system-info/battery-status.html On 2014/05/01 01:19:50, Nils Barth wrote: > ...
6 years, 7 months ago (2014-05-01 09:33:16 UTC) #11
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 7 months ago (2014-05-01 09:33:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/203683002/20001
6 years, 7 months ago (2014-05-01 09:33:33 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 09:43:48 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink
6 years, 7 months ago (2014-05-01 09:43:49 UTC) #15
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 7 months ago (2014-05-01 10:57:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/203683002/20001
6 years, 7 months ago (2014-05-01 10:57:33 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 11:04:26 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink
6 years, 7 months ago (2014-05-01 11:04:26 UTC) #19
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-01 11:12:04 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/203683002/20001
6 years, 7 months ago (2014-05-01 11:12:15 UTC) #21
Nils Barth (inactive)
haraken, could this get an ok? (nop change, fixes to accord with spec)
6 years, 7 months ago (2014-05-01 11:12:28 UTC) #22
commit-bot: I haz the power
Change committed as 173079
6 years, 7 months ago (2014-05-01 11:18:58 UTC) #23
haraken
6 years, 7 months ago (2014-05-01 11:21:16 UTC) #24
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698