Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2036803004: Reset ThreadState weak callback stack before GCing. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset ThreadState weak callback stack before GCing. In the event a thread gets to participate in more than one GC before it manages to leave its safe point, clear out its weak callback stack before initiating a new GC. Otherwise we risk keeping around weak callbacks to duplicate or dead objects. R= BUG=611702 Committed: https://crrev.com/423c887243774bcf76886b34c007c5d68cf93414 Cr-Commit-Position: refs/heads/master@{#397904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/heap/CallbackStack.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/CallbackStack.cpp View 2 chunks +17 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look. blink_heap_unittests do reproduce these non-empty thread stacks on some tests (ThreadedStrongification ...
4 years, 6 months ago (2016-06-03 18:05:30 UTC) #3
haraken
LGTM. Nice detective work!
4 years, 6 months ago (2016-06-03 23:30:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036803004/1
4 years, 6 months ago (2016-06-04 04:50:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 04:54:40 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 04:56:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/423c887243774bcf76886b34c007c5d68cf93414
Cr-Commit-Position: refs/heads/master@{#397904}

Powered by Google App Engine
This is Rietveld 408576698