Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2036773004: X87: Turbofan: Modify WASM linkage to store floats using only 4 bytes. (Closed)

Created:
4 years, 6 months ago by zhengxing.li
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Turbofan: Modify WASM linkage to store floats using only 4 bytes. port 817b59c8ad7e9237d93a43a31045285418bbb6d5 (r36654) original commit message: Adds instructions for ARM to push floats. BUG= Committed: https://crrev.com/486f8dd899bb1bdcc13fb81297cd8a27e61762ad Cr-Commit-Position: refs/heads/master@{#36704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 6 months ago (2016-06-03 09:11:01 UTC) #2
Weiliang
lgtm
4 years, 6 months ago (2016-06-03 09:12:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036773004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036773004/1
4 years, 6 months ago (2016-06-03 09:25:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 09:49:37 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 09:51:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/486f8dd899bb1bdcc13fb81297cd8a27e61762ad
Cr-Commit-Position: refs/heads/master@{#36704}

Powered by Google App Engine
This is Rietveld 408576698