Issue 2036763003: MD User Manager: Fixes flaky tests

Moe

Description was changed from ========== MD User Manager: Fixes flaky tests BUG=563722 ========== to ========== ...

4 years, 6 months ago (2016-06-03 13:33:32 UTC) #1

Moe

mahmadi@chromium.org changed reviewers: + michaelpg@chromium.org

4 years, 6 months ago (2016-06-03 13:56:05 UTC) #3

Moe

Description was changed from ========== MD User Manager: Fixes flaky tests 1) Call setTimeout after ...

4 years, 6 months ago (2016-06-03 13:59:53 UTC) #5

michaelpg

Have you been able to determine whether this actually reduces flakiness? (either way lgtm)

4 years, 6 months ago (2016-06-03 14:00:09 UTC) #6

Moe

On 2016/06/03 14:00:09, michaelpg wrote: > Have you been able to determine whether this actually ...

4 years, 6 months ago (2016-06-03 14:16:22 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036763003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036763003/20001

4 years, 6 months ago (2016-06-03 14:17:47 UTC) #9

commit-bot: I haz the power

Description was changed from ========== MD User Manager: Fixes flaky tests 1) Call setTimeout after ...

4 years, 6 months ago (2016-06-03 15:27:06 UTC) #10

commit-bot: I haz the power

Description was changed from ========== MD User Manager: Fixes flaky tests 1) Call setTimeout after ...

4 years, 6 months ago (2016-06-03 15:29:06 UTC) #12

commit-bot: I haz the power

4 years, 6 months ago (2016-06-03 15:29:07 UTC) #13

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0b328a01eaa0ce82bd374c26f2ba72de098e6d2d
Cr-Commit-Position: refs/heads/master@{#397715}

Moe

4 years, 6 months ago (2016-06-06 14:21:54 UTC) #14

Message was sent while issue was closed.

Description was changed from

==========
MD User Manager: Fixes flaky tests

1) Call setTimeout after each test.
user_manager.js includes a bunch of other js files that do operations
asynchronously. This is to make sure those operations are done after each test.

2) Do not clear <body> before the tests execute.
js files included in the user_manager.js expect some elements to exist on the
page. Therefore we can't test MD User Manager Polymer elements in isolation.

BUG=563722

Committed: https://crrev.com/0b328a01eaa0ce82bd374c26f2ba72de098e6d2d
Cr-Commit-Position: refs/heads/master@{#397715}
==========

to

==========
MD User Manager: Fixes flaky tests

1) Call setTimeout after each test.
user_manager.js includes a bunch of other js files that do operations
asynchronously. This is to make sure those operations are done after each test.

2) Do not clear <body> before the tests execute.
js files included in the user_manager.js expect some elements to exist on the
page. Therefore we can't test MD User Manager Polymer elements in isolation.

BUG=563722, 613191

Committed: https://crrev.com/0b328a01eaa0ce82bd374c26f2ba72de098e6d2d
Cr-Commit-Position: refs/heads/master@{#397715}
==========

Issue 2036763003: MD User Manager: Fixes flaky tests (Closed)

Description

Patch Set 1 : Initial #

Messages