Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 2036723003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //gpu (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //gpu The raw pointer overload of ListValue::Append() is deprecated and will be removed. Instead, code should just write: - ListValue::AppendBoolean() - ListValue::AppendInteger() - ListValue::AppendDouble() - ListValue::AppendString() BUG=581865 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/73391a46a77dcafa1fb8b555542f4defeb7e9ed4 Cr-Commit-Position: refs/heads/master@{#397604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gpu/config/gpu_control_list.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dcheng
4 years, 6 months ago (2016-06-02 22:21:38 UTC) #3
piman
lgtm
4 years, 6 months ago (2016-06-03 00:39:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036723003/1
4 years, 6 months ago (2016-06-03 00:57:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 02:50:17 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 02:54:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73391a46a77dcafa1fb8b555542f4defeb7e9ed4
Cr-Commit-Position: refs/heads/master@{#397604}

Powered by Google App Engine
This is Rietveld 408576698