Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3835)

Unified Diff: chrome/gpu/arc_video_accelerator.h

Issue 2036723002: Limit the number of ARC codec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed owenlin and posciak's comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/gpu/arc_video_accelerator.h
diff --git a/chrome/gpu/arc_video_accelerator.h b/chrome/gpu/arc_video_accelerator.h
index 4c99fe05ec6b83bdc4c2ef892e12856e3ec694c6..b4d32979520b9c10323e7f89d509cc1a88374165 100644
--- a/chrome/gpu/arc_video_accelerator.h
+++ b/chrome/gpu/arc_video_accelerator.h
@@ -52,11 +52,13 @@ struct VideoFormat {
// Chromium and the output buffers are returned back to Android side.
class ArcVideoAccelerator {
public:
- enum Error {
+ enum Result {
+ NO_ERROR = 0,
Pawel Osciak 2016/06/06 05:49:13 Hm, actually, now that this is a Result, we could
kcwu 2016/06/06 06:53:12 Done.
ILLEGAL_STATE = 1,
INVALID_ARGUMENT = 2,
UNREADABLE_INPUT = 3,
PLATFORM_FAILURE = 4,
+ INSUFFICIENT_RESOURCES = 5,
};
struct Config {
@@ -81,7 +83,7 @@ class ArcVideoAccelerator {
// Called when an asynchronous error happens. The errors in Initialize()
// will not be reported here, but will be indicated by a false return value
Pawel Osciak 2016/06/06 05:49:13 This also needs an update please.
kcwu 2016/06/06 06:53:12 Done.
// there.
- virtual void OnError(Error error) = 0;
+ virtual void OnError(Result error) = 0;
// Called when a buffer with the specified |index| and |port| has been
// processed and is no longer used in the accelerator. For input buffers,
@@ -104,8 +106,8 @@ class ArcVideoAccelerator {
// Initializes the ArcVideoAccelerator with specific configuration. This
// must be called before any other methods. This call is synchronous and
- // returns true iff initialization is successful.
- virtual bool Initialize(const Config& config, Client* client) = 0;
+ // returns NO_ERROR iff initialization is successful.
+ virtual Result Initialize(const Config& config, Client* client) = 0;
// Assigns a shared memory to be used for the accelerator at the specified
// port and index. A buffer must be successfully bound before it can be passed

Powered by Google App Engine
This is Rietveld 408576698