chrome/gpu/gpu_arc_video_service.h - Issue 2036723002: Limit the number of ARC codec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/gpu/gpu_arc_video_service.h

Issue 2036723002: Limit the number of ARC codec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address dcheng's comments: static_assert Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/gpu/gpu_arc_video_service.h

diff --git a/chrome/gpu/gpu_arc_video_service.h b/chrome/gpu/gpu_arc_video_service.h

index 0762f4eb6dbf2a182b2aa7c4f9a66608d2243974..054ac0b16afcbda1532ff8fb66611b26080f4eff 100644

--- a/chrome/gpu/gpu_arc_video_service.h

+++ b/chrome/gpu/gpu_arc_video_service.h

@@ -33,7 +33,7 @@ class GpuArcVideoService : public ::arc::mojom::VideoAcceleratorService,

private:

// ArcVideoAccelerator::Client implementation.

- void OnError(ArcVideoAccelerator::Error error) override;

+ void OnError(ArcVideoAccelerator::Result error) override;

void OnBufferDone(PortType port,

uint32_t index,

const BufferMetadata& metadata) override;

@@ -44,6 +44,9 @@ class GpuArcVideoService : public ::arc::mojom::VideoAcceleratorService,

// ::arc::mojom::VideoAcceleratorService implementation.

void Initialize(::arc::mojom::ArcVideoAcceleratorConfigPtr config,

const InitializeCallback& callback) override;

+ void DeprecatedInitialize(

+ ::arc::mojom::ArcVideoAcceleratorConfigPtr config,

+ const DeprecatedInitializeCallback& callback) override;

void BindSharedMemory(::arc::mojom::PortType port,

uint32_t index,

mojo::ScopedHandle ashmem_handle,

« no previous file with comments | « chrome/gpu/arc_video_accelerator.h ('k') | chrome/gpu/gpu_arc_video_service.cc » ('j') | no next file with comments »