Chromium Code Reviews| Index: chrome/gpu/arc_video_accelerator.h |
| diff --git a/chrome/gpu/arc_video_accelerator.h b/chrome/gpu/arc_video_accelerator.h |
| index 4c99fe05ec6b83bdc4c2ef892e12856e3ec694c6..a82d81b9bf97031b600d916e0dd4e28da1a3d934 100644 |
| --- a/chrome/gpu/arc_video_accelerator.h |
| +++ b/chrome/gpu/arc_video_accelerator.h |
| @@ -53,10 +53,12 @@ struct VideoFormat { |
| class ArcVideoAccelerator { |
| public: |
| enum Error { |
|
Pawel Osciak
2016/06/03 03:56:18
Should we call it Result instead of Error, if NO_E
kcwu
2016/06/03 13:14:15
Done.
Note, OnError becomes:
void OnError(Result
|
| + NO_ERROR = 0, |
| ILLEGAL_STATE = 1, |
| INVALID_ARGUMENT = 2, |
| UNREADABLE_INPUT = 3, |
| PLATFORM_FAILURE = 4, |
| + INSUFFICIENT_RESOURCES = 5, |
| }; |
| struct Config { |
| @@ -105,7 +107,7 @@ class ArcVideoAccelerator { |
| // Initializes the ArcVideoAccelerator with specific configuration. This |
| // must be called before any other methods. This call is synchronous and |
| // returns true iff initialization is successful. |
|
Pawel Osciak
2016/06/03 03:56:18
Please update documentation.
|
| - virtual bool Initialize(const Config& config, Client* client) = 0; |
| + virtual Error Initialize(const Config& config, Client* client) = 0; |
| // Assigns a shared memory to be used for the accelerator at the specified |
| // port and index. A buffer must be successfully bound before it can be passed |