Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7550)

Unified Diff: chrome/gpu/arc_gpu_video_decode_accelerator.h

Issue 2036723002: Limit the number of ARC codec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/gpu/arc_gpu_video_decode_accelerator.h
diff --git a/chrome/gpu/arc_gpu_video_decode_accelerator.h b/chrome/gpu/arc_gpu_video_decode_accelerator.h
index 5685f56e57136381ba1d81dd38b568a7b78f13d8..f6fa16ce7f56276f67dba33612b25eab41e299ac 100644
--- a/chrome/gpu/arc_gpu_video_decode_accelerator.h
+++ b/chrome/gpu/arc_gpu_video_decode_accelerator.h
@@ -32,8 +32,9 @@ class ArcGpuVideoDecodeAccelerator
~ArcGpuVideoDecodeAccelerator() override;
// Implementation of the ArcVideoAccelerator interface.
- bool Initialize(const Config& config,
- ArcVideoAccelerator::Client* client) override;
+ ArcVideoAccelerator::Error Initialize(
+ const Config& config,
+ ArcVideoAccelerator::Client* client) override;
void SetNumberOfOutputBuffers(size_t number) override;
void BindSharedMemory(PortType port,
uint32_t index,
@@ -119,6 +120,9 @@ class ArcGpuVideoDecodeAccelerator
// Returns |nullptr| if it cannot be found.
InputRecord* FindInputRecord(int32_t bitstream_buffer_id);
+ // Global counter that keeps track how many VDAs in use for ARC.
Pawel Osciak 2016/06/03 03:56:18 I think we mean ArcVideoDecodeAccelerator instead
kcwu 2016/06/03 13:14:15 I revised all variable name and comments. 'client
+ static int arc_codec_count_;
Pawel Osciak 2016/06/03 03:56:18 Please add a comment about locking here.
kcwu 2016/06/03 13:14:15 Done.
+
std::unique_ptr<media::VideoDecodeAccelerator> vda_;
// It's safe to use the pointer here, the life cycle of the |arc_client_|
« no previous file with comments | « no previous file | chrome/gpu/arc_gpu_video_decode_accelerator.cc » ('j') | chrome/gpu/arc_gpu_video_decode_accelerator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698