tools/clang/scripts/blink_gc_plugin_flags.py - Issue 2036683002: [iOS] Remove dependency third_party/WebKit on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/scripts/blink_gc_plugin_flags.py

Issue 2036683002: [iOS] Remove dependency third_party/WebKit on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment explaining why target are conditionally defined Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/scripts/blink_gc_plugin_flags.py

diff --git a/tools/clang/scripts/blink_gc_plugin_flags.py b/tools/clang/scripts/blink_gc_plugin_flags.py

index c2b8762bcb7414e079b9554dd9661fc5231efd94..b6c513f1e67827f81698598979a6b63171719d50 100755

--- a/tools/clang/scripts/blink_gc_plugin_flags.py

+++ b/tools/clang/scripts/blink_gc_plugin_flags.py

@@ -23,6 +23,9 @@ for arg in sys.argv[1:]:

FLAGS += PREFIX + 'warn-unneeded-finalizer'

elif arg.startswith('custom_clang_lib_path='):

CLANG_LIB_PATH = arg[len('custom_clang_lib_path='):]

+ elif arg == 'target_os=ios':

+ sys.stderr.write('error: blink is unsupported on iOS\n')

+ sys.exit(1)

if not sys.platform in ['win32', 'cygwin']:

LIBSUFFIX = 'dylib' if sys.platform == 'darwin' else 'so'