third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp - Issue 2036663003: Establish mojo service between Canvas (blink) and SurfaceManager (browser)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Issue 2036663003: Establish mojo service between Canvas (blink) and SurfaceManager (browser) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN build in android_dbg_recipe Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLCanvasElement.h ('k') | third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.h » ('j') | third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

index 3fca8d69353d0607e53a5837bceffd04d0eed656..bc7980cffdbe683be401b2fe88390a6a0439c866 100644

--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

@@ -58,6 +58,7 @@

#include "platform/RuntimeEnabledFeatures.h"

#include "platform/graphics/Canvas2DImageBufferSurface.h"

#include "platform/graphics/CanvasMetrics.h"

+#include "platform/graphics/CanvasSurfaceLayerBridgeClientImpl.h"

#include "platform/graphics/ExpensiveCanvasHeuristicParameters.h"

#include "platform/graphics/ImageBuffer.h"

#include "platform/graphics/RecordingImageBufferSurface.h"

@@ -1174,9 +1175,12 @@ String HTMLCanvasElement::getIdFromControl(const Element* element)

return String();

}

-void HTMLCanvasElement::createSurfaceLayerBridge()

+bool HTMLCanvasElement::createSurfaceLayer()

{

- m_surfaceLayerBridge = adoptPtr(new CanvasSurfaceLayerBridge());

+ DCHECK(!m_surfaceLayerBridge);

+ OwnPtr<CanvasSurfaceLayerBridgeClient> bridgeClient = adoptPtr(new CanvasSurfaceLayerBridgeClientImpl());

+ m_surfaceLayerBridge = adoptPtr(new CanvasSurfaceLayerBridge(std::move(bridgeClient)));

+ return m_surfaceLayerBridge->createSurfaceLayer(this->width(), this->height());

}

} // namespace blink