Revert of Revert "Compress .pak resources with new option: "type=GZIPPABLE_BINDATA""

Reland of: Compress .pak resources with new option: "type=GZIPPABLE_BINDATA"

Reason for reland:
No longer fails on chromeos host

Allows compression via gzip for rarely used .pak resources. These resources
will only be uncompressed into memory upon request of the resource. We are
compressing all "internals" pages, with a savings of 472KB.

First attempt:
https://codereview.chromium.org/1968993002

TBR=agrieve
BUG=609219
Committed: https://crrev.com/c19426aba4e6aef9cb4fefc02d37969f9002ba5c
Cr-Commit-Position: refs/heads/master@{#398303}

[smaier, 2016-06-02 20:40:41]

Created Revert of Revert "Compress .pak resources with new option:
"type=GZIPPABLE_BINDATA""

[xdai1, 2016-06-02 20:58:18]

On 2016/06/02 20:40:41, smaier wrote:
> Created Revert of Revert "Compress .pak resources with new option:
> "type=GZIPPABLE_BINDATA""

Please make sure you fix the problem before re-landing it. Otherwise you will
break the PFQ again. See crbug.com/616798 for why it gets reverted.

[smaier, 2016-06-02 21:17:50]

Description was changed from

==========
Revert of Revert "Compress .pak resources with new option:
"type=GZIPPABLE_BINDATA"" (patchset #1 id:1 of
https://codereview.chromium.org/2034473004/ )

Reason for revert:
Do not review

Original issue's description:
> Revert "Compress .pak resources with new option: "type=GZIPPABLE_BINDATA""
> 
> This reverts commit e3a06a21aa1a7adfaef988488cdbcccbfa9a2ef6.
> 
> This CL breaks all PFQ at the BuildPackages stage. See the infomational
builder
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/lumpy-tot-chr...
as an example.
> 
> TBR=smaier@chromium.org
> BUG=616798
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
> 
> Committed:
https://chromium.googlesource.com/chromium/src/+/49624437b555e0020e0addf2b3c8...

TBR=xdai@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616798
==========

to

==========
Revert of Revert "Compress .pak resources with new option:
"type=GZIPPABLE_BINDATA"" (patchset #1 id:1 of
https://codereview.chromium.org/2034473004/ )

Reason for revert:
Do not review

Original issue's description:
> Revert "Compress .pak resources with new option: "type=GZIPPABLE_BINDATA""
> 
> This reverts commit e3a06a21aa1a7adfaef988488cdbcccbfa9a2ef6.
> 
> This CL breaks all PFQ at the BuildPackages stage. See the infomational
builder
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/lumpy-tot-chr...
as an example.
> 
> TBR=smaier@chromium.org
> BUG=616798
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
> 
> Committed:
https://chromium.googlesource.com/chromium/src/+/49624437b555e0020e0addf2b3c8...

TBR=xdai@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616798
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[smaier, 2016-06-02 22:11:44]

Description was changed from

==========
Revert of Revert "Compress .pak resources with new option:
"type=GZIPPABLE_BINDATA"" (patchset #1 id:1 of
https://codereview.chromium.org/2034473004/ )

Reason for revert:
Do not review

Original issue's description:
> Revert "Compress .pak resources with new option: "type=GZIPPABLE_BINDATA""
> 
> This reverts commit e3a06a21aa1a7adfaef988488cdbcccbfa9a2ef6.
> 
> This CL breaks all PFQ at the BuildPackages stage. See the infomational
builder
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/lumpy-tot-chr...
as an example.
> 
> TBR=smaier@chromium.org
> BUG=616798
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
> 
> Committed:
https://chromium.googlesource.com/chromium/src/+/49624437b555e0020e0addf2b3c8...

TBR=xdai@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616798
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Revert of Revert "Compress .pak resources with new option:
"type=GZIPPABLE_BINDATA"" (patchset #1 id:1 of
https://codereview.chromium.org/2034473004/ )

Fixing issue for builds taking place on a ChromeOS machine.
==========

[smaier, 2016-06-02 22:11:44]

smaier@chromium.org changed reviewers:
+ agrieve@chromium.org, flackr@chromium.org

[smaier, 2016-06-02 22:31:54]

Description was changed from

==========
Revert of Revert "Compress .pak resources with new option:
"type=GZIPPABLE_BINDATA"" (patchset #1 id:1 of
https://codereview.chromium.org/2034473004/ )

Fixing issue for builds taking place on a ChromeOS machine.
==========

to

==========
Revert of Revert "Compress .pak resources with new option:
"type=GZIPPABLE_BINDATA"" (patchset #1 id:1 of
https://codereview.chromium.org/2034473004/ )

Fixing issue for builds taking place on a ChromeOS machine.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[smaier, 2016-06-03 21:32:50]

flackr@ Take a look at tools/grit/grit/node/include.py. Everything else should
be identical to the first CL I uploaded

[smaier, 2016-06-06 19:19:26]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 19:20:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2036633003/350001

[flackr, 2016-06-06 20:00:58]

lgtm with nit.

https://codereview.chromium.org/2036633003/diff/350001/tools/grit/grit/node/i...
File tools/grit/grit/node/include.py (right):

https://codereview.chromium.org/2036633003/diff/350001/tools/grit/grit/node/i...
tools/grit/grit/node/include.py:103: if sys.platform == 'linux2' and 'chromeos'
not in self.GetRoot().defines:
Can you file and reference a bug explaining the reasons we can't do rsyncable
gzip on most platforms? We can then discuss on the bug whether we want to fix it
(e.g. patch rsyncable into chromeos or wait for gzip 1.8 and/or we could
implement rsyncable gzip in python based on zlib).

[commit-bot: I haz the power, 2016-06-06 20:58:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 20:58:43]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[smaier, 2016-06-07 14:04:45]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 14:04:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2036633003/370001

[agrieve, 2016-06-07 14:52:37]

Description was changed from

==========
Revert of Revert "Compress .pak resources with new option:
"type=GZIPPABLE_BINDATA"" (patchset #1 id:1 of
https://codereview.chromium.org/2034473004/ )

Fixing issue for builds taking place on a ChromeOS machine.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Reland of: Compress .pak resources with new option: "type=GZIPPABLE_BINDATA"

Reason for reland:
No longer fails on chromeos host

Allows compression via gzip for rarely used .pak resources. These resources
will only be uncompressed into memory upon request of the resource. We are
compressing all "internals" pages, with a savings of 472KB.

First attempt:
https://codereview.chromium.org/1968993002

TBR=agrieve
BUG=609219
==========

[agrieve, 2016-06-07 14:52:51]

The CQ bit was unchecked by agrieve@chromium.org

[agrieve, 2016-06-07 14:52:55]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-06-07 14:52:56]

The patchset sent to the CQ was uploaded after l-g-t-m from flackr@chromium.org
Link to the patchset: https://codereview.chromium.org/2036633003/#ps370001
(title: "Updated comment to reference --rsyncable bug.")

[commit-bot: I haz the power, 2016-06-07 14:53:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2036633003/370001

[commit-bot: I haz the power, 2016-06-07 15:17:30]

Description was changed from

==========
Reland of: Compress .pak resources with new option: "type=GZIPPABLE_BINDATA"

Reason for reland:
No longer fails on chromeos host

Allows compression via gzip for rarely used .pak resources. These resources
will only be uncompressed into memory upon request of the resource. We are
compressing all "internals" pages, with a savings of 472KB.

First attempt:
https://codereview.chromium.org/1968993002

TBR=agrieve
BUG=609219
==========

to

==========
Reland of: Compress .pak resources with new option: "type=GZIPPABLE_BINDATA"

Reason for reland:
No longer fails on chromeos host

Allows compression via gzip for rarely used .pak resources. These resources
will only be uncompressed into memory upon request of the resource. We are
compressing all "internals" pages, with a savings of 472KB.

First attempt:
https://codereview.chromium.org/1968993002

TBR=agrieve
BUG=609219
==========

[commit-bot: I haz the power, 2016-06-07 15:17:31]

Committed patchset #6 (id:370001)

[commit-bot: I haz the power, 2016-06-07 15:19:59]

Description was changed from

==========
Reland of: Compress .pak resources with new option: "type=GZIPPABLE_BINDATA"

Reason for reland:
No longer fails on chromeos host

Allows compression via gzip for rarely used .pak resources. These resources
will only be uncompressed into memory upon request of the resource. We are
compressing all "internals" pages, with a savings of 472KB.

First attempt:
https://codereview.chromium.org/1968993002

TBR=agrieve
BUG=609219
==========

to

==========
Reland of: Compress .pak resources with new option: "type=GZIPPABLE_BINDATA"

Reason for reland:
No longer fails on chromeos host

Allows compression via gzip for rarely used .pak resources. These resources
will only be uncompressed into memory upon request of the resource. We are
compressing all "internals" pages, with a savings of 472KB.

First attempt:
https://codereview.chromium.org/1968993002

TBR=agrieve
BUG=609219

Committed: https://crrev.com/c19426aba4e6aef9cb4fefc02d37969f9002ba5c
Cr-Commit-Position: refs/heads/master@{#398303}
==========

[commit-bot: I haz the power, 2016-06-07 15:20:01]

Patchset 6 (id:??) landed as
https://crrev.com/c19426aba4e6aef9cb4fefc02d37969f9002ba5c
Cr-Commit-Position: refs/heads/master@{#398303}