mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl - Issue 2036623002: Validate map keys in C++ Mojo bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

Issue 2036623002: Validate map keys in C++ Mojo bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom ('k') | mojo/public/tools/bindings/generators/mojom_cpp_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

index 5dabf24d09af12ea3d0f7c9c94dd0ae8a7f72412..9aeb92a1cc3123172b4d8e74a3bfe08e40f16861 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl

@@ -27,7 +27,7 @@

}

{%- elif kind|is_map_kind %}

const mojo::internal::ArrayValidateParams {{name}}_validate_params(

- {{kind.value_kind|get_map_validate_params_ctor_args|indent(6)}});

+ {{kind|get_array_validate_params_ctor_args|indent(6)}});

if (!mojo::internal::ValidateMap({{field_expr}}, bounds_checker,

&{{name}}_validate_params)) {

return false;