Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_entry.data

Issue 2036623002: Validate map keys in C++ Mojo bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_entry.data
diff --git a/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd10_one_null_key.data b/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_entry.data
similarity index 58%
copy from mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd10_one_null_key.data
copy to mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_entry.data
index 9127a26c25eca70652abca164f0fcb2f9b73929e..9a981cb2f3b707e185db10bc221d5a31c70a3b65 100644
--- a/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd10_one_null_key.data
+++ b/mojo/public/interfaces/bindings/tests/data/validation/conformance_mthd16_uknown_non_extensible_enum_map_entry.data
@@ -1,15 +1,15 @@
[dist4]message_header // num_bytes
[u4]0 // version
[u4]0 // interface ID
-[u4]10 // name
+[u4]16 // name
[u4]0 // flags
[u4]0 // padding
[anchr]message_header
-[dist4]method10_params // num_bytes
+[dist4]method16_params // num_bytes
[u4]0 // version
[dist8]map_data_ptr // param0
-[anchr]method10_params
+[anchr]method16_params
[anchr]map_data_ptr
[dist4]map_data_struct_header // num_bytes
@@ -19,22 +19,17 @@
[anchr]map_data_struct_header
[anchr]key_array_ptr
-[dist4]key_array_member // num_bytes
-[u4]2 // num_elements
-[dist8]key_string_1
-[u8]0 // one null key
+[dist4]key_array_member // num_bytes
+[u4]2 // num_elements
+[u4]0x5678 // Unknown value is not allowed for non-extensible
+ // enum.
+[u4]1
[anchr]key_array_member
-[anchr]key_string_1
-[dist4]key_string_1_member // num_bytes
-[u4]5 // num_elements
-0 1 2 3 4
-[anchr]key_string_1_member
-
-[u4]0 [u4]0 [u1]0 [u1]0 [u1]0 // manual padding for array alignment
-
[anchr]value_array_ptr
[dist4]value_array_member // num_bytes
[u4]2 // num_elements
-1 2
+[u4]0x5678 // Unknown value is not allowed for non-extensible
yzshen1 2016/06/02 19:52:28 Please consider splitting this test into two, one
tibell 2016/06/02 23:55:02 Done.
+ // enum.
+[u4]1
[anchr]value_array_member

Powered by Google App Engine
This is Rietveld 408576698