Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: android_webview/browser/render_thread_manager.cc

Issue 2036563002: Delete OnscreenDisplayClient and TopLevelDisplayClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: onscreendisplayclient: webview-scoped-allow-gl-for-hardwarerenderer-constructor Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « android_webview/browser/hardware_renderer.cc ('k') | cc/cc.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/render_thread_manager.h" 5 #include "android_webview/browser/render_thread_manager.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "android_webview/browser/child_frame.h" 9 #include "android_webview/browser/child_frame.h"
10 #include "android_webview/browser/compositor_frame_producer.h" 10 #include "android_webview/browser/compositor_frame_producer.h"
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 } 280 }
281 } 281 }
282 282
283 ScopedAppGLStateRestore state_restore( 283 ScopedAppGLStateRestore state_restore(
284 draw_info->mode == AwDrawGLInfo::kModeDraw 284 draw_info->mode == AwDrawGLInfo::kModeDraw
285 ? ScopedAppGLStateRestore::MODE_DRAW 285 ? ScopedAppGLStateRestore::MODE_DRAW
286 : ScopedAppGLStateRestore::MODE_RESOURCE_MANAGEMENT); 286 : ScopedAppGLStateRestore::MODE_RESOURCE_MANAGEMENT);
287 // Set the correct FBO before kModeDraw. The GL commands run in kModeDraw 287 // Set the correct FBO before kModeDraw. The GL commands run in kModeDraw
288 // require a correctly bound FBO. The FBO remains until the next kModeDraw. 288 // require a correctly bound FBO. The FBO remains until the next kModeDraw.
289 // So kModeProcess between kModeDraws has correctly bound FBO, too. 289 // So kModeProcess between kModeDraws has correctly bound FBO, too.
290 if (draw_info->mode == AwDrawGLInfo::kModeDraw && !hardware_renderer_ &&
291 !IsInsideHardwareRelease() && HasFrameForHardwareRendererOnRT()) {
292 hardware_renderer_.reset(new HardwareRenderer(this));
293 hardware_renderer_->CommitFrame();
294 }
295 if (hardware_renderer_) { 290 if (hardware_renderer_) {
296 hardware_renderer_->SetBackingFrameBufferObject( 291 hardware_renderer_->SetBackingFrameBufferObject(
297 state_restore.framebuffer_binding_ext()); 292 state_restore.framebuffer_binding_ext());
298 } 293 }
299 294
300 ScopedAllowGL allow_gl; 295 ScopedAllowGL allow_gl;
296 if (!hardware_renderer_ && draw_info->mode == AwDrawGLInfo::kModeDraw &&
297 !IsInsideHardwareRelease() && HasFrameForHardwareRendererOnRT()) {
298 hardware_renderer_.reset(new HardwareRenderer(this));
299 hardware_renderer_->SetBackingFrameBufferObject(
300 state_restore.framebuffer_binding_ext());
301 hardware_renderer_->CommitFrame();
302 }
301 303
302 if (draw_info->mode == AwDrawGLInfo::kModeProcessNoContext) { 304 if (draw_info->mode == AwDrawGLInfo::kModeProcessNoContext) {
303 LOG(ERROR) << "Received unexpected kModeProcessNoContext"; 305 LOG(ERROR) << "Received unexpected kModeProcessNoContext";
304 } 306 }
305 307
306 if (IsInsideHardwareRelease()) { 308 if (IsInsideHardwareRelease()) {
307 hardware_renderer_has_frame_ = false; 309 hardware_renderer_has_frame_ = false;
308 hardware_renderer_.reset(); 310 hardware_renderer_.reset();
309 // Flush the idle queue in tear down. 311 // Flush the idle queue in tear down.
310 DeferredGpuCommandService::GetInstance()->PerformAllIdleWork(); 312 DeferredGpuCommandService::GetInstance()->PerformAllIdleWork();
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 : render_thread_manager_(render_thread_manager) { 395 : render_thread_manager_(render_thread_manager) {
394 DCHECK(!render_thread_manager_->IsInsideHardwareRelease()); 396 DCHECK(!render_thread_manager_->IsInsideHardwareRelease());
395 render_thread_manager_->SetInsideHardwareRelease(true); 397 render_thread_manager_->SetInsideHardwareRelease(true);
396 } 398 }
397 399
398 RenderThreadManager::InsideHardwareReleaseReset::~InsideHardwareReleaseReset() { 400 RenderThreadManager::InsideHardwareReleaseReset::~InsideHardwareReleaseReset() {
399 render_thread_manager_->SetInsideHardwareRelease(false); 401 render_thread_manager_->SetInsideHardwareRelease(false);
400 } 402 }
401 403
402 } // namespace android_webview 404 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/browser/hardware_renderer.cc ('k') | cc/cc.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698