Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2036553002: cc: Add four new histograms for gpu image decode/upload usage tracking. (Closed)

Created:
4 years, 6 months ago by vmpstr
Modified:
4 years, 6 months ago
Reviewers:
Ilya Sherman, ericrk
CC:
chromium-reviews, cc-bugs_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add four new histograms for gpu image decode/upload usage tracking. This patch adds the following new histograms: Renderer4.GpuImageDecodeState ============================= This records the state of the software decode used for gpu upload. Specifically, it identifies whether the decode was used or not used and whether it was used/wasted once or several times. The possible states are all combinations of those values: - Used, once - Wasted, once - Used, relocked - Wasted, relocked Renderer4.GpuImageDecodeState.FirstLockWasted ============================================= This indicates whether the first lock of the decode described above was used. This is important, since if we waste the first decode, we lose the guarantee that we can relock and upload this without doing more work Renderer4.GpuImageUploadState.Used ================================== This indicates whether the uploaded image was used in raster. Renderer4.GpuImageUploadState.FirstRefWasted ============================================ This indicates whether the uploaded image was used during the first ref. In other words, if the ref reached 0 for the first time without the image being used, this would record "true, it was wasted". R=ericrk CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/8bf48dca03c3dd6345b1c94500d7a73a5f69ba46 Cr-Commit-Position: refs/heads/master@{#397766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -2 lines) Patch
M cc/tiles/gpu_image_decode_controller.h View 2 chunks +26 lines, -0 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller.cc View 5 chunks +67 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
vmpstr
Please take a look.
4 years, 6 months ago (2016-06-01 23:53:50 UTC) #2
ericrk
LGTM - thanks for adding this!
4 years, 6 months ago (2016-06-02 20:08:45 UTC) #3
vmpstr
+isherman for histograms.xml. Please take a look.
4 years, 6 months ago (2016-06-02 20:43:53 UTC) #5
Ilya Sherman
LGTM
4 years, 6 months ago (2016-06-02 21:42:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036553002/1
4 years, 6 months ago (2016-06-03 17:13:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/81706)
4 years, 6 months ago (2016-06-03 18:19:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036553002/1
4 years, 6 months ago (2016-06-03 18:21:50 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 18:52:32 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 18:54:17 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bf48dca03c3dd6345b1c94500d7a73a5f69ba46
Cr-Commit-Position: refs/heads/master@{#397766}

Powered by Google App Engine
This is Rietveld 408576698