Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2036543003: Allow uint16 and uint32 in MakeKey. (Closed)

Created:
4 years, 6 months ago by iannucci
Modified:
4 years, 6 months ago
Reviewers:
dnj, dnj (Google), nodir
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/gae@add_default_version_hostname
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M service/datastore/key.go View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2037433002 Patch 60001

Messages

Total messages: 8 (4 generated)
iannucci
4 years, 6 months ago (2016-06-02 00:40:28 UTC) #1
dnj (Google)
lgtm
4 years, 6 months ago (2016-06-02 03:49:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036543003/20001
4 years, 6 months ago (2016-06-02 22:36:01 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 22:40:37 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/47a59f64219fcbb9664e22499748a1e4a9f1d448

Powered by Google App Engine
This is Rietveld 408576698