Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2036523003: S390: Store Floats as 4 bytes and Double as 8 bytes for codegen (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Store Floats as 4 bytes and Double as 8 bytes for codegen R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/4d8bcd11011a52a4677e498b1dd1cba5b4e21f5f Cr-Commit-Position: refs/heads/master@{#36691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 3 chunks +36 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 6 months ago (2016-06-02 21:45:08 UTC) #1
JaideepBajwa
lgtm
4 years, 6 months ago (2016-06-02 21:49:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036523003/1
4 years, 6 months ago (2016-06-02 21:50:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 22:13:26 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 22:15:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d8bcd11011a52a4677e498b1dd1cba5b4e21f5f
Cr-Commit-Position: refs/heads/master@{#36691}

Powered by Google App Engine
This is Rietveld 408576698