Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: xfa/fxjse/cfxjse_arguments.h

Issue 2036513002: Stop casting struct CFXJSE_ArgumentsImpl to unrelated class CFXJSE_Arguments (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Explicit ctor Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | xfa/fxjse/class.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxjse/cfxjse_arguments.h
diff --git a/xfa/fxjse/cfxjse_arguments.h b/xfa/fxjse/cfxjse_arguments.h
index 48a3bfff8f1188647c2ee8d13a07baa6af770d6e..3028d39def7c2011e53dca1f435aa27bb18feea3 100644
--- a/xfa/fxjse/cfxjse_arguments.h
+++ b/xfa/fxjse/cfxjse_arguments.h
@@ -11,6 +11,10 @@
class CFXJSE_Arguments {
public:
+ CFXJSE_Arguments(const v8::FunctionCallbackInfo<v8::Value>* pInfo,
+ CFXJSE_Value* pRetValue)
+ : m_pInfo(pInfo), m_pRetValue(pRetValue) {}
+
v8::Isolate* GetRuntime() const;
int32_t GetLength() const;
std::unique_ptr<CFXJSE_Value> GetValue(int32_t index) const;
@@ -20,6 +24,10 @@ class CFXJSE_Arguments {
CFX_ByteString GetUTF8String(int32_t index) const;
void* GetObject(int32_t index, CFXJSE_Class* pClass = nullptr) const;
CFXJSE_Value* GetReturnValue();
+
+ private:
+ const v8::FunctionCallbackInfo<v8::Value>* m_pInfo;
+ CFXJSE_Value* m_pRetValue;
};
#endif // XFA_FXJSE_CFXJSE_ARGUMENTS_H_
« no previous file with comments | « no previous file | xfa/fxjse/class.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698