Stop casting struct CFXJSE_ArgumentsImpl to unrelated class CFXJSE_Arguments

xfa/fxjse/class.h

Index: xfa/fxjse/class.h
diff --git a/xfa/fxjse/class.h b/xfa/fxjse/class.h
index 344adf4a47803c74695042568e738ab33308f740..8ab83cbdf065d6a5a21b701190bdc66006ccfcaf 100644
--- a/xfa/fxjse/class.h
+++ b/xfa/fxjse/class.h
@@ -15,14 +15,6 @@ class CFXJSE_Context;
 class CFXJSE_Value;
 
 class CFXJSE_Class {
- protected:
-  CFXJSE_Class(CFXJSE_Context* lpContext)
-      : m_lpClassDefinition(nullptr), m_pContext(lpContext) {}
-
- public:
-  inline CFXJSE_Context* GetContext() { return m_pContext; }
-  inline v8::Global<v8::FunctionTemplate>& GetTemplate() { return m_hTemplate; }
-
  public:
   static CFXJSE_Class* Create(CFXJSE_Context* pContext,
                               const FXJSE_CLASS_DESCRIPTOR* lpClassDefintion,
@@ -34,7 +26,13 @@ class CFXJSE_Class {
       v8::Local<v8::ObjectTemplate>& hObjectTemplate,
       const FXJSE_CLASS_DESCRIPTOR* lpClassDefinition);
 
+  CFXJSE_Context* GetContext() { return m_pContext; }
+  v8::Global<v8::FunctionTemplate>& GetTemplate() { return m_hTemplate; }
+
  protected:
+  CFXJSE_Class(CFXJSE_Context* lpContext)

[Lei Zhang, 2016/06/01 23:42:52]

explict

[Tom Sepez, 2016/06/01 23:47:15]

Done.

+      : m_lpClassDefinition(nullptr), m_pContext(lpContext) {}
+
   CFX_ByteString m_szClassName;
   const FXJSE_CLASS_DESCRIPTOR* m_lpClassDefinition;
   CFXJSE_Context* m_pContext;
@@ -42,9 +40,5 @@ class CFXJSE_Class {
   friend class CFXJSE_Context;
   friend class CFXJSE_Value;
 };
-struct CFXJSE_ArgumentsImpl {
-  const v8::FunctionCallbackInfo<v8::Value>* m_pInfo;
-  CFXJSE_Value* m_pRetValue;
-};
 
 #endif  // XFA_FXJSE_CLASS_H_