src/runtime/runtime-forin.cc - Issue 2036493006: Keep prototype maps in dictionary mode until ICs see them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-forin.cc

Issue 2036493006: Keep prototype maps in dictionary mode until ICs see them (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: make ignition tests happy Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-forin.cc

diff --git a/src/runtime/runtime-forin.cc b/src/runtime/runtime-forin.cc

index 68c1092bd6cae138245a27ec73c8395f5b52715f..421b395e5db7e52af787e24e1151f65a84608285 100644

--- a/src/runtime/runtime-forin.cc

+++ b/src/runtime/runtime-forin.cc

@@ -22,6 +22,7 @@ namespace {

// deletions during a for-in.

MaybeHandle<HeapObject> Enumerate(Handle<JSReceiver> receiver) {

Isolate* const isolate = receiver->GetIsolate();

+ JSObject::MakePrototypesFast(receiver, kStartAtReceiver, isolate);

FastKeyAccumulator accumulator(isolate, receiver,

KeyCollectionMode::kIncludePrototypes,

ENUMERABLE_STRINGS);

« no previous file with comments | « src/runtime/runtime-debug.cc ('k') | src/string-stream.cc » ('j') | no next file with comments »