src/lookup.cc - Issue 2036493006: Keep prototype maps in dictionary mode until ICs see them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.cc

Issue 2036493006: Keep prototype maps in dictionary mode until ICs see them (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: make ignition tests happy Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/lookup.cc

diff --git a/src/lookup.cc b/src/lookup.cc

index cc3b8a4b6af1980f512b1f33a855fc70c8169a29..69020a776b0c87a16133c0e205c8650f8b2b52a9 100644

--- a/src/lookup.cc

+++ b/src/lookup.cc

@@ -496,8 +496,7 @@ bool LookupIterator::HolderIsReceiverOrHiddenPrototype() const {

if (!current->map()->has_hidden_prototype()) return false;

// JSProxy do not occur as hidden prototypes.

if (object->IsJSProxy()) return false;

- PrototypeIterator iter(isolate(), current,

- PrototypeIterator::START_AT_PROTOTYPE,

+ PrototypeIterator iter(isolate(), current, kStartAtPrototype,

PrototypeIterator::END_AT_NON_HIDDEN);

while (!iter.IsAtEnd()) {

if (iter.GetCurrent<JSReceiver>() == object) return true;

« no previous file with comments | « src/keys.cc ('k') | src/messages.cc » ('j') | no next file with comments »