src/ic/handler-compiler.cc - Issue 2036493006: Keep prototype maps in dictionary mode until ICs see them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/handler-compiler.cc

Issue 2036493006: Keep prototype maps in dictionary mode until ICs see them (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: make ignition tests happy Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/handler-compiler.cc

diff --git a/src/ic/handler-compiler.cc b/src/ic/handler-compiler.cc

index 7d953cb3fcdca34fb2108ea39b708aec3406e8ed..cf7c6b1f1c1cf84d0f02bccdc5959ba45d921507 100644

--- a/src/ic/handler-compiler.cc

+++ b/src/ic/handler-compiler.cc

@@ -444,8 +444,7 @@ Handle<Code> NamedStoreHandlerCompiler::CompileStoreTransition(

PrototypeIterator::WhereToEnd end =

name->IsPrivate() ? PrototypeIterator::END_AT_NON_HIDDEN

: PrototypeIterator::END_AT_NULL;

- PrototypeIterator iter(isolate(), holder(),

- PrototypeIterator::START_AT_PROTOTYPE, end);

+ PrototypeIterator iter(isolate(), holder(), kStartAtPrototype, end);

while (!iter.IsAtEnd()) {

last = PrototypeIterator::GetCurrent<JSObject>(iter);

iter.Advance();

« no previous file with comments | « src/globals.h ('k') | src/ic/ic.cc » ('j') | no next file with comments »