src/runtime/runtime-forin.cc - Issue 2036493006: Keep prototype maps in dictionary mode until ICs see them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-forin.cc

Issue 2036493006: Keep prototype maps in dictionary mode until ICs see them (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix tests & rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-forin.cc

diff --git a/src/runtime/runtime-forin.cc b/src/runtime/runtime-forin.cc

index 68c1092bd6cae138245a27ec73c8395f5b52715f..49bb692bcd1c68d07ebfb1680e9f99a66cf1ce25 100644

--- a/src/runtime/runtime-forin.cc

+++ b/src/runtime/runtime-forin.cc

@@ -110,6 +110,7 @@ RUNTIME_FUNCTION(Runtime_ForInEnumerate) {

HandleScope scope(isolate);

DCHECK_EQ(1, args.length());

CONVERT_ARG_HANDLE_CHECKED(JSReceiver, receiver, 0);

+ JSObject::MakePrototypesFast(receiver, true /* include_receiver */, isolate);

Toon Verwaest 2016/06/07 14:48:06 Given all these /* include_receiver */, what about

Jakob Kummerow 2016/06/08 12:19:00 Done.

RETURN_RESULT_OR_FAILURE(isolate, Enumerate(receiver));

}