Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: src/crankshaft/hydrogen.cc

Issue 2036493006: Keep prototype maps in dictionary mode until ICs see them (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: make ignition tests happy Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/hydrogen.h" 5 #include "src/crankshaft/hydrogen.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/allocation-site-scopes.h" 9 #include "src/allocation-site-scopes.h"
10 #include "src/ast/ast-numbering.h" 10 #include "src/ast/ast-numbering.h"
(...skipping 8079 matching lines...) Expand 10 before | Expand all | Expand 10 after
8090 HInstruction* HGraphBuilder::BuildConstantMapCheck(Handle<JSObject> constant) { 8090 HInstruction* HGraphBuilder::BuildConstantMapCheck(Handle<JSObject> constant) {
8091 HCheckMaps* check = Add<HCheckMaps>( 8091 HCheckMaps* check = Add<HCheckMaps>(
8092 Add<HConstant>(constant), handle(constant->map())); 8092 Add<HConstant>(constant), handle(constant->map()));
8093 check->ClearDependsOnFlag(kElementsKind); 8093 check->ClearDependsOnFlag(kElementsKind);
8094 return check; 8094 return check;
8095 } 8095 }
8096 8096
8097 8097
8098 HInstruction* HGraphBuilder::BuildCheckPrototypeMaps(Handle<JSObject> prototype, 8098 HInstruction* HGraphBuilder::BuildCheckPrototypeMaps(Handle<JSObject> prototype,
8099 Handle<JSObject> holder) { 8099 Handle<JSObject> holder) {
8100 PrototypeIterator iter(isolate(), prototype, 8100 PrototypeIterator iter(isolate(), prototype, kStartAtReceiver);
8101 PrototypeIterator::START_AT_RECEIVER);
8102 while (holder.is_null() || 8101 while (holder.is_null() ||
8103 !PrototypeIterator::GetCurrent(iter).is_identical_to(holder)) { 8102 !PrototypeIterator::GetCurrent(iter).is_identical_to(holder)) {
8104 BuildConstantMapCheck(PrototypeIterator::GetCurrent<JSObject>(iter)); 8103 BuildConstantMapCheck(PrototypeIterator::GetCurrent<JSObject>(iter));
8105 iter.Advance(); 8104 iter.Advance();
8106 if (iter.IsAtEnd()) { 8105 if (iter.IsAtEnd()) {
8107 return NULL; 8106 return NULL;
8108 } 8107 }
8109 } 8108 }
8110 return BuildConstantMapCheck(PrototypeIterator::GetCurrent<JSObject>(iter)); 8109 return BuildConstantMapCheck(PrototypeIterator::GetCurrent<JSObject>(iter));
8111 } 8110 }
(...skipping 5589 matching lines...) Expand 10 before | Expand all | Expand 10 after
13701 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 13700 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
13702 } 13701 }
13703 13702
13704 #ifdef DEBUG 13703 #ifdef DEBUG
13705 graph_->Verify(false); // No full verify. 13704 graph_->Verify(false); // No full verify.
13706 #endif 13705 #endif
13707 } 13706 }
13708 13707
13709 } // namespace internal 13708 } // namespace internal
13710 } // namespace v8 13709 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698