Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2036493004: Add gm for displaying different variants of 8888. (Closed)

Created:
4 years, 6 months ago by herb_g
Modified:
4 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add gm for displaying different variants of 8888 bitmaps and fix a small rejection case for sprite blitters. BUG=skia:5378 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2036493004 Committed: https://skia.googlesource.com/skia/+/5823846397066377b65e011a42becd2d665110ad

Patch Set 1 #

Patch Set 2 : Simplify test and move check. #

Patch Set 3 : Sync pdf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
M gm/all_bitmap_configs.cpp View 1 2 chunks +67 lines, -1 line 0 comments Download
M src/core/SkBlitter_Sprite.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
herb_g
4 years, 6 months ago (2016-06-02 20:44:46 UTC) #4
herb_g
Simplify test and move check.
4 years, 6 months ago (2016-06-02 22:04:51 UTC) #5
herb_g
Thanks for the suggestions. PTAL
4 years, 6 months ago (2016-06-02 22:06:33 UTC) #6
reed1
lgtm
4 years, 6 months ago (2016-06-02 22:12:29 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036493004/20001
4 years, 6 months ago (2016-06-03 14:13:47 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/8882)
4 years, 6 months ago (2016-06-03 14:22:00 UTC) #11
herb_g
Sync pdf
4 years, 6 months ago (2016-06-03 16:18:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036493004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036493004/40001
4 years, 6 months ago (2016-06-03 16:19:38 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 16:44:57 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5823846397066377b65e011a42becd2d665110ad

Powered by Google App Engine
This is Rietveld 408576698