Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2036493002: Handle touch accessibility in PageWidgetDelegate instead of WebViewImpl. (Closed)

Created:
4 years, 6 months ago by dmazzoni
Modified:
4 years, 6 months ago
Reviewers:
pdr., dcheng
CC:
aboxhall+watch_chromium.org, blink-reviews, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, kinuko+watch, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@touch_exploration_test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle touch accessibility in PageWidgetDelegate instead of WebViewImpl. WebViewImpl::handleInputEvent isn't called for out-of-process iframes. Move the touch accessibility code to PageWidgetDelegate instead, so that it's called from both contexts. This is a follow-up to ecrrev.com/2009283002 BUG=613694 Committed: https://crrev.com/2fa74e5fca5dc25616b23ba7d098db48f33e2d90 Cr-Commit-Position: refs/heads/master@{#397356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M content/browser/accessibility/touch_accessibility_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PageWidgetDelegate.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -16 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
dmazzoni
4 years, 6 months ago (2016-06-01 22:30:06 UTC) #2
dcheng
lgtm
4 years, 6 months ago (2016-06-01 23:08:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036493002/1
4 years, 6 months ago (2016-06-02 07:09:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 10:45:49 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 10:47:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fa74e5fca5dc25616b23ba7d098db48f33e2d90
Cr-Commit-Position: refs/heads/master@{#397356}

Powered by Google App Engine
This is Rietveld 408576698