Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2036473002:
Enable new WebGL pixel tests. (Closed)
|
Created:
4 years, 6 months ago by erikchen Modified:
4 years, 6 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable new WebGL pixel tests.
All the reference images have been generated.
BUG=607130
Committed: https://crrev.com/24291cdf807dfea8d98a9aa17f09a50132b02360
Cr-Commit-Position: refs/heads/master@{#397338}
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
Description was changed from ========== Enable new WebGL pixel tests. All the reference images have been generated. BUG=607130 ========== to ========== Enable new WebGL pixel tests. All the reference images have been generated. BUG=607130 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
erikchen@chromium.org changed reviewers: + kbr@chromium.org
kbr: Please review. I manually verified the following reference images: gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_AA_Alpha_v1_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_NoAA_Alpha_v1_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_AA_NoAlpha_v1_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_NoAA_NoAlpha_v1_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_AA_AlphaES3_v1_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_NoAA_AlphaES3_v1_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_AA_NoAlphaES3_v1_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_NoAA_NoAlphaES3_v1_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_NonChromiumImage_AA_Alpha_v1_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_NonChromiumImage_NoAA_Alpha_v1_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_NonChromiumImage_AA_NoAlpha_v1_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_NonChromiumImage_NoAA_NoAlpha_v1_mac_8086_0a2e_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_AA_Alpha_v1_win_1002_6779_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_NoAA_Alpha_v1_win_1002_6779_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_AA_NoAlpha_v1_win_1002_6779_msaa.png gs://chromium-gpu-archive/reference-images/Pixel_WebGLGreenTriangle_NoAA_NoAlpha_v1_win_1002_6779_msaa.png
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036473002/1
Excellent. Thanks for being so thorough. LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036473002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036473002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036473002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable new WebGL pixel tests. All the reference images have been generated. BUG=607130 ========== to ========== Enable new WebGL pixel tests. All the reference images have been generated. BUG=607130 Committed: https://crrev.com/24291cdf807dfea8d98a9aa17f09a50132b02360 Cr-Commit-Position: refs/heads/master@{#397338} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/24291cdf807dfea8d98a9aa17f09a50132b02360 Cr-Commit-Position: refs/heads/master@{#397338} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
