Use nav_entry_id in UpdateTitle for OOPIF-enabled modes.

Use nav_entry_id in UpdateTitle for OOPIF-enabled modes.

Keep the DCHECK in default mode for now, until we discover why page_id
and nav_entry_id don't agree when there are no OOPIFs.

BUG=616609, 577449, 369661
TEST=See bug 616609 for repro steps.

Committed: https://crrev.com/0bfe528899739beaab8587e7c6ee9277209e0c63
Cr-Commit-Position: refs/heads/master@{#397321}

[Charlie Reis, 2016-06-01 22:10:23]

creis@chromium.org changed reviewers:
+ avi@chromium.org

[Charlie Reis, 2016-06-01 22:10:23]

Avi, can you review?  In retrospect, it's obvious why they wouldn't agree in
OOPIF-enabled modes, since the main frame's RVH doesn't update its page_id when
an OOPIF commits.  We should just switch over in those modes.

I'd like to track down why they differ in default mode, though, so I'm leaving
the DCHECK in for that case (in case we get a similar set of repro steps like
https://codereview.chromium.org/2022083002).

CC'ing Alex, since I copied some of the title checking logic from his
CrossSiteIframeBlockedByParentCSPFromMeta test.

[alexmos, 2016-06-01 22:30:08]

alexmos@chromium.org changed reviewers:
+ alexmos@chromium.org

[alexmos, 2016-06-01 22:30:08]

> CC'ing Alex, since I copied some of the title checking logic from his
> CrossSiteIframeBlockedByParentCSPFromMeta test.

And also CC'ing lukasza@, since he actually wrote that test and not me. :)  The
fix itself looks great.

[Avi (use Gerrit), 2016-06-02 03:29:13]

lgtm

[Charlie Reis, 2016-06-02 05:59:45]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-06-02 06:00:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2036463002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2036463002/1

[commit-bot: I haz the power, 2016-06-02 06:46:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-02 06:49:08]

Description was changed from

==========
Use nav_entry_id in UpdateTitle for OOPIF-enabled modes.

Keep the DCHECK in default mode for now, until we discover why page_id
and nav_entry_id don't agree when there are no OOPIFs.

BUG=616609, 577449, 369661
TEST=See bug 616609 for repro steps.
==========

to

==========
Use nav_entry_id in UpdateTitle for OOPIF-enabled modes.

Keep the DCHECK in default mode for now, until we discover why page_id
and nav_entry_id don't agree when there are no OOPIFs.

BUG=616609, 577449, 369661
TEST=See bug 616609 for repro steps.

Committed: https://crrev.com/0bfe528899739beaab8587e7c6ee9277209e0c63
Cr-Commit-Position: refs/heads/master@{#397321}
==========

[commit-bot: I haz the power, 2016-06-02 06:49:09]

Patchset 1 (id:??) landed as
https://crrev.com/0bfe528899739beaab8587e7c6ee9277209e0c63
Cr-Commit-Position: refs/heads/master@{#397321}