third_party/WebKit/public/web/WebFrameClient.h - Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix SwapMainFrame test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/ChromeClientImpl.cpp ('K') | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | third_party/WebKit/public/web/WebFrameWidget.h » ('j') | third_party/WebKit/public/web/WebFrameWidget.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/web/WebFrameClient.h

diff --git a/third_party/WebKit/public/web/WebFrameClient.h b/third_party/WebKit/public/web/WebFrameClient.h

index d8d94066207f125798398a30754cc574b75d11f5..397667946e6d4b27f03c0bb986a1d7352a461c19 100644

--- a/third_party/WebKit/public/web/WebFrameClient.h

+++ b/third_party/WebKit/public/web/WebFrameClient.h

@@ -175,7 +175,7 @@ public:

enum class DetachType { Remove, Swap };

// This frame has been detached from the view, but has not been closed yet.

- virtual void frameDetached(WebFrame*, DetachType) { }

+ virtual void frameDetached(WebLocalFrame*, DetachType) {}

// This frame has become focused..

virtual void frameFocused() { }