third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp - Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp ('K') | « third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp b/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

index 7f1ffe7bdb4a25b2c30a1331189ea63864997872..71af8a435ef59dee6007019bb61944de5ef6dcdd 100644

--- a/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

+++ b/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

@@ -437,6 +437,8 @@ TEST(RemoteFrameThrottlingTest, ThrottledLocalRoot)

WebFrameOwnerProperties properties;

WebRemoteFrame* rootFrame = webView->mainFrame()->toWebRemoteFrame();

WebLocalFrame* localFrame = FrameTestHelpers::createLocalChild(rootFrame);

+ FrameTestHelpers::TestWebWidgetClient widgetClient;

+ WebWidget* widget = WebFrameWidget::create(&widgetClient, localFrame);

WebString baseURL("http://internal.test/");

URLTestHelpers::registerMockedURLFromBaseURL(baseURL, "simple_div.html");

@@ -466,6 +468,7 @@ TEST(RemoteFrameThrottlingTest, ThrottledLocalRoot)

frameView->updateAllLifecyclePhases();

testing::runPendingTasks();

EXPECT_EQ(DocumentLifecycle::VisualUpdatePending, frameDocument->lifecycle().state());

+ widget->close();

webView->close();

}