Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: third_party/WebKit/public/web/WebFrameWidget.h

Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix SwapMainFrame test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 19 matching lines...) Expand all
30 30
31 #ifndef WebFrameWidget_h 31 #ifndef WebFrameWidget_h
32 #define WebFrameWidget_h 32 #define WebFrameWidget_h
33 33
34 #include "../platform/WebCommon.h" 34 #include "../platform/WebCommon.h"
35 #include "../platform/WebPageVisibilityState.h" 35 #include "../platform/WebPageVisibilityState.h"
36 #include "public/web/WebWidget.h" 36 #include "public/web/WebWidget.h"
37 37
38 namespace blink { 38 namespace blink {
39 39
40 class CompositorAnimationTimeline;
40 class CompositorProxyClient; 41 class CompositorProxyClient;
42 class GraphicsLayer;
41 class WebLocalFrame; 43 class WebLocalFrame;
42 class WebView; 44 class WebView;
43 class WebWidgetClient; 45 class WebWidgetClient;
44 46
45 class WebFrameWidget : public WebWidget { 47 class WebFrameWidget : public WebWidget {
46 public: 48 public:
47 BLINK_EXPORT static WebFrameWidget* create(WebWidgetClient*, WebLocalFrame*) ; 49 BLINK_EXPORT static WebFrameWidget* create(WebWidgetClient*, WebLocalFrame*) ;
48 // Creates a frame widget for a WebView. Temporary helper to help transition 50 // Creates a frame widget for a WebView. Temporary helper to help transition
49 // away from WebView inheriting WebWidget. 51 // away from WebView inheriting WebWidget.
50 // TODO(dcheng): Remove once transition is complete. 52 // TODO(dcheng): Remove once transition is complete.
(...skipping 21 matching lines...) Expand all
72 virtual void setBaseBackgroundColor(WebColor) = 0; 74 virtual void setBaseBackgroundColor(WebColor) = 0;
73 75
74 // TODO(dcheng): Temporary: there should only be one WebFrameWidget 76 // TODO(dcheng): Temporary: there should only be one WebFrameWidget
75 // implementation but the Blink API is currently in a transition state. 77 // implementation but the Blink API is currently in a transition state.
76 // See https://goo.gl/7yVrnb. These methods should only be used inside 78 // See https://goo.gl/7yVrnb. These methods should only be used inside
77 // blink. 79 // blink.
78 virtual bool forSubframe() const { return true; } 80 virtual bool forSubframe() const { return true; }
79 virtual void scheduleAnimation() = 0; 81 virtual void scheduleAnimation() = 0;
80 virtual CompositorProxyClient* createCompositorProxyClient() = 0; 82 virtual CompositorProxyClient* createCompositorProxyClient() = 0;
81 virtual WebWidgetClient* client() const = 0; 83 virtual WebWidgetClient* client() const = 0;
84 virtual void setRootGraphicsLayer(GraphicsLayer*) = 0;
dcheng 2016/07/04 07:34:36 Hmm, can we move the Blink-internal methods to the
lfg 2016/07/04 17:46:13 Done.
85 virtual void attachCompositorAnimationTimeline(CompositorAnimationTimeline*) = 0;
86 virtual void detachCompositorAnimationTimeline(CompositorAnimationTimeline*) = 0;
82 }; 87 };
83 88
84 } // namespace blink 89 } // namespace blink
85 90
86 #endif 91 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698